1138865 - Make the MOZ_ANDROID_TAB_QUEUE app constant rely on the nightly flag

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

It's unlikely that we'll want the tab queue to appear in anything but a nightly build whilst it's in development, so let's make the tab queue constant rely on the nightly build flag.

Comment 1

[Martyn Haigh (:mhaigh)]

Attachment: Bug 1138865 - Make the MOZ_ANDROID_TAB_QUEUE app constant rely on the nightly flag

This adds a dependancy for the MOZ_ANDROID_TAB_QUEUE constant on the NIGHT_BUILD flag - this is mainly a convenience change so we can avoid the noise of having to write "if(AppConstants.MOZ_ANDROID_TAB_QUEUE && AppConstants.NIGHT_BUILD)..."

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8571890 [details] [diff] [review]
Bug 1138865 - Make the MOZ_ANDROID_TAB_QUEUE app constant rely on the nightly flag

Review of attachment 8571890 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/AppConstants.java.in
@@ +174,4 @@
>  //#endif
>  
>      public static final boolean MOZ_ANDROID_TAB_QUEUE =
> +//#if defined(MOZ_ANDROID_TAB_QUEUE) && defined(NIGHTLY_BUILD)

This is confusing; we should set MOZ_ANDROID_TAB_QUEUE depending on NIGHTLY_BUILD by default.  I don't see an example of this, but we should be able to do it in mobile/android/confvars.sh.

Comment 3

[Nick Alexander :nalexander [he/him]]

Patches like https://hg.mozilla.org/mozilla-central/rev/d8fd7efe9ea6 show how it can be done.  You could depend on NIGHTLY_BUILD or ! RELEASE_BUILD (which is Nightly and Aurora).

Comment 4

[Martyn Haigh (:mhaigh)]

Currently I want to be able to set the MOZ_ANDROID_TAB_QUEUE app const based on the NIGHTLY_BUILD AND having an entry in your mozconfig.  I think that by adding something to the confvar file we get rid of the mozconfig dependancy, right?

Comment 5

[Nick Alexander :nalexander [he/him]]

(In reply to Martyn Haigh (:mhaigh) from comment #4)
> Currently I want to be able to set the MOZ_ANDROID_TAB_QUEUE app const based
> on the NIGHTLY_BUILD AND having an entry in your mozconfig.  I think that by
> adding something to the confvar file we get rid of the mozconfig dependancy,
> right?

Hey, I tried to discuss this with you in #mobile, but you've been ill :(  I don't think you should do this.  If I ask for a setting in my mozconfig, it shouldn't be conditional on Nightly as well.  (This is just going to screw the rare person who tries to build trunk-as-beta, for example.)  So I suggest:

* landing this preffed off (everywhere) and having the ability to pref it on in mozconfig (unconditionally);
* eventually landing this preffed on in Nightly in confvars.sh.

If there's a strong reason for doing otherwise, let me know.