RTSP not enabled in Lollipop

RESOLVED FIXED in Firefox 39, Firefox OS v2.2

Status

--
major
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ggrisco, Assigned: ethan)

Tracking

({verifyme})

unspecified
2.2 S7 (6mar)
ARM
Gonk (Firefox OS)
verifyme

Firefox Tracking Flags

(blocking-b2g:2.2+, firefox37 wontfix, firefox38 wontfix, firefox39 fixed, b2g-v2.2 fixed, b2g-master fixed)

Details

(Whiteboard: [caf priority: p2][CR 802468])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
It seems RTSP has not been enabled on Lollipop. The MOZ_RTSP flag is set on Kitkat (19) bot not Lollipop (21).

Updated

4 years ago
Whiteboard: [CR 802468]

Updated

4 years ago
Whiteboard: [CR 802468] → [caf priority: p2][CR 802468]

Comment 1

4 years ago
Hi Vincent & Shawn,

Can you help us find an owner for this fxOS 2.2 FL CAF blocker?

Ethan Tseng seems to be someone who's worked in this are in the past via https://bugzilla.mozilla.org/show_bug.cgi?id=929372#c9

Thanks,
Mike
Flags: needinfo?(vchang)
Flags: needinfo?(sku)
Yeah, that's right. Ethan is working on this.
Assignee: nobody → ettseng
Flags: needinfo?(vchang)
Flags: needinfo?(sku)

Updated

4 years ago
Attachment #8573010 - Flags: review?(ettseng)
(Assignee)

Comment 4

4 years ago
Comment on attachment 8573010 [details]
Patch

Keven,

Thanks for your patch.
We will apply this patch and verify all RTSP function works well.
Thus, we'll take over this bug.

Thanks. :)
Attachment #8573010 - Flags: review?(ettseng) → review-
(Assignee)

Comment 5

4 years ago
Comment on attachment 8573010 [details]
Patch

Oops! I just wanted to cancel the review request, not meant to r-.
Sorry about that.
Attachment #8573010 - Flags: review-
(Assignee)

Comment 6

4 years ago
Created attachment 8573029 [details] [diff] [review]
bug-1138983-fix.patch

what this patch does:
1. Add commit message.
2. Add code comment for the new argument of queueDiscontinuity().

Jonathan, since your already built nexus-5-l, please help to apply this patch and test RTSP function. Thanks.
Attachment #8573010 - Attachment is obsolete: true
Attachment #8573029 - Flags: feedback?(jhao)

Comment 7

4 years ago
(In reply to Ethan Tseng [:ethan] from comment #4)
> Comment on attachment 8573010 [details]
> Patch
> 
> Keven,
> 
> Thanks for your patch.
> We will apply this patch and verify all RTSP function works well.
> Thus, we'll take over this bug.
> 
> Thanks. :)

Thanks

--
Keven
(Assignee)

Comment 8

4 years ago
Additional remark:
I don't know the appropriate situation to use "|discard|=false" when calling queueDiscontinuity(). However, at least it is right to set |disard|=true when RTSP handles seek discontinuity.

Comment 9

4 years ago
Triage: blocking
blocking-b2g: 2.2? → 2.2+
Comment on attachment 8573029 [details] [diff] [review]
bug-1138983-fix.patch

Review of attachment 8573029 [details] [diff] [review]:
-----------------------------------------------------------------

I've done some basic testing. RTSP is working well.
Attachment #8573029 - Flags: feedback+
Attachment #8573029 - Flags: feedback?(jhao)
(Assignee)

Comment 11

4 years ago
(In reply to Jonathan Hao [:jhao] from comment #10)
> I've done some basic testing. RTSP is working well.
Glad to hear this. Thanks Jonathan!
(Assignee)

Comment 12

4 years ago
Comment on attachment 8573029 [details] [diff] [review]
bug-1138983-fix.patch

Vincent,
Please help to review this patch. Thanks.
Attachment #8573029 - Flags: review?(vchang)
Comment on attachment 8573029 [details] [diff] [review]
bug-1138983-fix.patch

Review of attachment 8573029 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/rtsp/rtsp/RTSPSource.cpp
@@ +507,5 @@
>  
>              TrackInfo *info = &mTracks.editItemAt(trackIndex);
>              sp<AnotherPacketSource> source = info->mSource;
>              if (source != NULL) {
> +#if ANDROID_VERSION >= 21

It seems no better way to prevent the compiler flag so far. Let's try to improve it in our refactor plan.
Attachment #8573029 - Flags: review?(vchang) → review+
(Assignee)

Comment 14

4 years ago
The result of Treeherder:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=215715029f5c
Keywords: checkin-needed
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/fcaa845b28e8
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S7 (6mar)
Comment on attachment 8573029 [details] [diff] [review]
bug-1138983-fix.patch

[Approval Request Comment]
User impact if declined: no RTSP for v2.2
Attachment #8573029 - Flags: approval-mozilla-b2g37?

Updated

4 years ago
Keywords: verifyme

Updated

4 years ago
Attachment #8573029 - Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/b3be5c1bc11c
status-b2g-v2.2: --- → fixed
status-b2g-master: --- → fixed
status-firefox37: --- → wontfix
status-firefox38: --- → wontfix

Updated

4 years ago
Blocks: 1142220

Updated

4 years ago
No longer blocks: 1142220
You need to log in before you can comment on or make changes to this bug.