Closed Bug 1138983 Opened 10 years ago Closed 10 years ago

RTSP not enabled in Lollipop

Categories

(Firefox OS Graveyard :: RTSP, defect)

ARM
Gonk (Firefox OS)
defect
Not set
major

Tracking

(blocking-b2g:2.2+, firefox37 wontfix, firefox38 wontfix, firefox39 fixed, b2g-v2.2 fixed, b2g-master fixed)

RESOLVED FIXED
2.2 S7 (6mar)
blocking-b2g 2.2+
Tracking Status
firefox37 --- wontfix
firefox38 --- wontfix
firefox39 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: ggrisco, Assigned: ethan)

References

Details

(Keywords: verifyme, Whiteboard: [caf priority: p2][CR 802468])

Attachments

(1 file, 1 obsolete file)

It seems RTSP has not been enabled on Lollipop. The MOZ_RTSP flag is set on Kitkat (19) bot not Lollipop (21).
Whiteboard: [CR 802468]
Whiteboard: [CR 802468] → [caf priority: p2][CR 802468]
Hi Vincent & Shawn, Can you help us find an owner for this fxOS 2.2 FL CAF blocker? Ethan Tseng seems to be someone who's worked in this are in the past via https://bugzilla.mozilla.org/show_bug.cgi?id=929372#c9 Thanks, Mike
Flags: needinfo?(vchang)
Flags: needinfo?(sku)
Yeah, that's right. Ethan is working on this.
Assignee: nobody → ettseng
Flags: needinfo?(vchang)
Flags: needinfo?(sku)
Attached file Patch (obsolete) —
Attachment #8573010 - Flags: review?(ettseng)
Comment on attachment 8573010 [details] Patch Keven, Thanks for your patch. We will apply this patch and verify all RTSP function works well. Thus, we'll take over this bug. Thanks. :)
Attachment #8573010 - Flags: review?(ettseng) → review-
Comment on attachment 8573010 [details] Patch Oops! I just wanted to cancel the review request, not meant to r-. Sorry about that.
Attachment #8573010 - Flags: review-
what this patch does: 1. Add commit message. 2. Add code comment for the new argument of queueDiscontinuity(). Jonathan, since your already built nexus-5-l, please help to apply this patch and test RTSP function. Thanks.
Attachment #8573010 - Attachment is obsolete: true
Attachment #8573029 - Flags: feedback?(jhao)
(In reply to Ethan Tseng [:ethan] from comment #4) > Comment on attachment 8573010 [details] > Patch > > Keven, > > Thanks for your patch. > We will apply this patch and verify all RTSP function works well. > Thus, we'll take over this bug. > > Thanks. :) Thanks -- Keven
Additional remark: I don't know the appropriate situation to use "|discard|=false" when calling queueDiscontinuity(). However, at least it is right to set |disard|=true when RTSP handles seek discontinuity.
Triage: blocking
blocking-b2g: 2.2? → 2.2+
Comment on attachment 8573029 [details] [diff] [review] bug-1138983-fix.patch Review of attachment 8573029 [details] [diff] [review]: ----------------------------------------------------------------- I've done some basic testing. RTSP is working well.
Attachment #8573029 - Flags: feedback+
Attachment #8573029 - Flags: feedback?(jhao)
(In reply to Jonathan Hao [:jhao] from comment #10) > I've done some basic testing. RTSP is working well. Glad to hear this. Thanks Jonathan!
Comment on attachment 8573029 [details] [diff] [review] bug-1138983-fix.patch Vincent, Please help to review this patch. Thanks.
Attachment #8573029 - Flags: review?(vchang)
Comment on attachment 8573029 [details] [diff] [review] bug-1138983-fix.patch Review of attachment 8573029 [details] [diff] [review]: ----------------------------------------------------------------- ::: netwerk/protocol/rtsp/rtsp/RTSPSource.cpp @@ +507,5 @@ > > TrackInfo *info = &mTracks.editItemAt(trackIndex); > sp<AnotherPacketSource> source = info->mSource; > if (source != NULL) { > +#if ANDROID_VERSION >= 21 It seems no better way to prevent the compiler flag so far. Let's try to improve it in our refactor plan.
Attachment #8573029 - Flags: review?(vchang) → review+
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S7 (6mar)
Comment on attachment 8573029 [details] [diff] [review] bug-1138983-fix.patch [Approval Request Comment] User impact if declined: no RTSP for v2.2
Attachment #8573029 - Flags: approval-mozilla-b2g37?
Keywords: verifyme
Attachment #8573029 - Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
No longer blocks: CAF-v3.0-FL-metabug
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: