1138990 - 64-bit windows xulrunner is busted

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[[e-mail] (:bhearsum)]

Hit this in 37.0b2:
AppData.cpp
c:/builds/moz2_slave/rel-m-beta-xr_w64_bld-00000000/build/obj-firefox/_virtualenv/Scripts/python.exe -m mozbuild.action.cl  cl -FoAppData.obj -c   -D_USE_ANSI_CPP -DXPCOM_GLUE -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -Ic:/builds/moz2_slave/rel-m-beta-xr_w64_bld-00000000/build/xpcom/glue/standalone/staticruntime -I. -Ic:/builds/moz2_slave/rel-m-beta-xr_w64_bld-00000000/build/xpcom/glue/standalone/staticruntime/../../../build -I../../../../dist/include   -Ic:/builds/moz2_slave/rel-m-beta-xr_w64_bld-00000000/build/obj-firefox/dist/include/nspr -Ic:/builds/moz2_slave/rel-m-beta-xr_w64_bld-00000000/build/obj-firefox/dist/include/nss        -MT            -FI ../../../../dist/include/mozilla-config.h -DMOZILLA_CLIENT  -TP -nologo -D_HAS_EXCEPTIONS=0 -W3 -Gy -FS -wd4251 -wd4244 -wd4267 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR-  -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -O1 -Oi -Oy -Zl  -Fdgenerated.pdb   c:/builds/moz2_slave/rel-m-beta-xr_w64_bld-00000000/build/xpcom/glue/AppData.cpp
FileUtils.obj
nsXPCOMGlue.cpp
c:\Program Files (x86)\Windows Kits\8.1\include\um\winbase.h(8839) : error C3861: '_InterlockedIncrement64': identifier not found
c:\Program Files (x86)\Windows Kits\8.1\include\um\winbase.h(8870) : error C3861: '_InterlockedDecrement64': identifier not found
c:\Program Files (x86)\Windows Kits\8.1\include\um\winbase.h(8906) : error C3861: '_InterlockedExchange64': identifier not found
c:\Program Files (x86)\Windows Kits\8.1\include\um\winbase.h(8960) : error C3861: '_InterlockedExchangeAdd64': identifier not found
c:\Program Files (x86)\Windows Kits\8.1\include\um\winbase.h(8970) : error C3861: '_InterlockedExchangeAdd64': identifier not found
c:\Program Files (x86)\Windows Kits\8.1\include\um\winbase.h(9017) : error C3861: '_InterlockedAnd64': identifier not found
c:\Program Files (x86)\Windows Kits\8.1\include\um\winbase.h(9027) : error C3861: '_InterlockedOr64': identifier not found
c:\Program Files (x86)\Windows Kits\8.1\include\um\winbase.h(9037) : error C3861: '_InterlockedXor64': identifier not found
c:/builds/moz2_slave/rel-m-beta-xr_w64_bld-00000000/build/config/rules.mk:930: recipe for target 'nsXPCOMGlue.obj' failed
mozmake.exe[5]: *** [nsXPCOMGlue.obj] Error 2
mozmake.exe[5]: *** Waiting for unfinished jobs....

Possibly rooted in the same issue as bug 1138922? That's just a guess based on both being Windows...

Comment 1

[Benjamin Smedberg]

What compiler is being used for these builds? Do the Fx mozconfigs differ in some significant way?

Comment 2

[[e-mail] (:bhearsum)]

Getting the complete mozconfig is a little tricky. Here's the root one for each though:
http://hg.mozilla.org/releases/mozilla-beta/file/bba77d7fde28/browser/config/mozconfigs/win64/release
http://hg.mozilla.org/releases/mozilla-beta/file/bba77d7fde28/xulrunner/config/mozconfigs/win64/xulrunner

We end using $topsrcdir/build/win32/mozconfig.vs2013-win64 for both.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Ben Hearsum [:bhearsum] from comment #2)
> Getting the complete mozconfig is a little tricky. Here's the root one for
> each though:
> http://hg.mozilla.org/releases/mozilla-beta/file/bba77d7fde28/browser/config/
> mozconfigs/win64/release
> http://hg.mozilla.org/releases/mozilla-beta/file/bba77d7fde28/xulrunner/
> config/mozconfigs/win64/xulrunner
> 
> We end using $topsrcdir/build/win32/mozconfig.vs2013-win64 for both.

No, we end using build/win64/mozconfig.vs2013 in browser, which is significantly different from build/win32/mozconfig.vs2013-win64. build/win32/mozconfig.vs2013-win64 is about win32 builds on win64 host.

Comment 4

[(Away)]

Can you share more details about the failure? I successfully built on mozilla-beta using this mozconfig:

ac_add_options --enable-application=xulrunner
ac_add_options --target=x86_64-pc-mingw32
ac_add_options --host=x86_64-pc-mingw32

at this revision:
changeset:   250236:8abdbdecd2d6
tag:         tip
user:        Chris Pearce <[e-mail]>
date:        Mon Mar 02 14:13:47 2015 +1300
summary:     Bug 1138240 - Fail faster if a CDM tries to resolve a resolved promise. r=edwin a=lmandel ba=lmandel

Comment 5

[[e-mail] (:bhearsum)]

(In reply to David Major [:dmajor] (UTC+13) from comment #4)
> Can you share more details about the failure? I successfully built on
> mozilla-beta using this mozconfig:
> 
> ac_add_options --enable-application=xulrunner
> ac_add_options --target=x86_64-pc-mingw32
> ac_add_options --host=x86_64-pc-mingw32
> 
> at this revision:
> changeset:   250236:8abdbdecd2d6
> tag:         tip
> user:        Chris Pearce <[e-mail]>
> date:        Mon Mar 02 14:13:47 2015 +1300
> summary:     Bug 1138240 - Fail faster if a CDM tries to resolve a resolved
> promise. r=edwin a=lmandel ba=lmandel

Based on your + glandium's comment it certainly seems like the mozconfig is wrong. I'll take another stay at fixing it.

Comment 6

[[e-mail] (:bhearsum)]

Attachment: fix compiler selection for win64 xulrunner

I think this is all that's needed...

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8572612 [details] [diff] [review]
fix compiler selection for win64 xulrunner

Review of attachment 8572612 [details] [diff] [review]:
-----------------------------------------------------------------

I think this should do.

Comment 8

[[e-mail] (:bhearsum)]

Comment on attachment 8572612 [details] [diff] [review]
fix compiler selection for win64 xulrunner

Thanks Mike. I've gone ahead and landed this (and on inbound. Once bug 1139403 is fixed we'll be able to verify it. I'll wait until that to uplift to aurora and beta.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b102a4cab3ae

Comment 10

[[e-mail] (:bhearsum)]

This patch worked, we have files like http://ftp.mozilla.org/pub/mozilla.org/xulrunner/nightly/2015-03-06-03-02-29-mozilla-central/xulrunner-39.0a1.en-US.win64.zip now.

Comment 11

[[e-mail] (:bhearsum)]

Comment on attachment 8572612 [details] [diff] [review]
fix compiler selection for win64 xulrunner

This patch fixes win64 xulrunner builds. We need it on Beta to ship XULRunner there.

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8572612 [details] [diff] [review]
fix compiler selection for win64 xulrunner

Beta+ Aurora+

Comment 13

[[e-mail] (:bhearsum)]

Comment on attachment 8572612 [details] [diff] [review]
fix compiler selection for win64 xulrunner

https://hg.mozilla.org/releases/mozilla-aurora/rev/a1cd7c036d45
https://hg.mozilla.org/releases/mozilla-beta/rev/52600b8172cf