Closed Bug 1138993 Opened 5 years ago Closed 5 years ago

Landscape pdf print preview generates one empty page for every page of the pdf file.

Categories

(Firefox :: PDF Viewer, defect, P1)

37 Branch
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox36 --- unaffected
firefox37 --- fixed
firefox38 --- fixed
firefox39 --- verified
firefox40 --- verified
firefox41 --- verified

People

(Reporter: VarCat, Assigned: Snuffleupagus)

References

Details

(Keywords: regression, Whiteboard: [pdfjs-c-integration][bugday-20150610])

Attachments

(2 files)

Environment:

FF 37.0b2
Build Id:20150302192546
OS: Windows 7 x64, Ubuntu 14.04 x32, Mac Os X 10.8.5

STR:

1. Open http://www.pdf995.com/samples/pdf.pdf on Firefox.
2. Go to File-> Print Preview and set Landscape

Issue:
For every page of the pdf file an empty page is generated in print preview.

Note:
When printing the linked pdf with the following properties:
- Landscape
- Pages per Sheet 2
the empty pages appear on the printed files.

This seems to be a regression as it's not reproducible on FF 36 but is reproducible on FF 37.0b1(build id:20150223185154)
Tracking user visible PDF print preview.

Gavin - As this occurs in print preview, will this be an pdf.js issue or a front-end issue?
Flags: needinfo?(gavin.sharp)
Flags: firefox-backlog?
No idea!
Flags: needinfo?(gavin.sharp)
pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=4793ea3d1a21&tochange=724554c093a8

Suspect: 	9e27809d4438	Ryan VanderMeulen — Bug 1117757 - Update pdf.js to version 1.0.1040. r=yury, r=Mossop
Any ideas, Yury?
Flags: needinfo?(ydelendik)
This is a regression from PR #5510, see https://github.com/mozilla/pdf.js/pull/5510.
Attachment #8573279 - Flags: review?(ydelendik)
Attachment #8573281 - Flags: review?(ydelendik)
Assignee: nobody → jonas.jenwald
Flags: needinfo?(ydelendik)
Attachment #8573279 - Flags: review?(ydelendik) → review+
Attachment #8573281 - Flags: review?(ydelendik) → review+
The aurora/beta patches back out https://github.com/mozilla/pdf.js/pull/5510 change. We are still investigating the best solution for mozilla-central, and would like to keep this bug open and continue tracking it. Once we have a solution it will be sync'ed with m-c.
Comment on attachment 8573279 [details] [diff] [review]
bug-1138993-aurora.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1117757
[User impact if declined]: print preview not working in landscape mode for PDF files
[Describe test coverage new/current, TreeHerder]: manual testing and Treeherder
[Risks and why]: low and only affects printing
[String/UUID change made/needed]: none
Attachment #8573279 - Flags: approval-mozilla-aurora?
Comment on attachment 8573281 [details] [diff] [review]
bug-1138993-beta.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1117757
[User impact if declined]: print preview not working in landscape mode for PDF files
[Describe test coverage new/current, TreeHerder]: manual testing and Treeherder
[Risks and why]: low and only affects printing
[String/UUID change made/needed]: none
Attachment #8573281 - Flags: approval-mozilla-beta?
Keywords: leave-open
Should we back this out of m-c while you work on a fix as well?
Flags: needinfo?(jonas.jenwald)
Comment on attachment 8573281 [details] [diff] [review]
bug-1138993-beta.patch

Taking the backout in Beta 3. Beta+ Aurora+
Attachment #8573281 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 8573279 [details] [diff] [review]
bug-1138993-aurora.patch

I meant that we're taking the backout in Beta 4.
Attachment #8573279 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #12)
> Should we back this out of m-c while you work on a fix as well?

As Yury said in comment 9, we'd rather avoid that and instead wait a little longer until we've landed a good solution for this upstream.
Flags: needinfo?(jonas.jenwald)
Keywords: checkin-needed
(In reply to Jonas Jenwald [:Snuffleupagus] from comment #15)
> (In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #12)
> > Should we back this out of m-c while you work on a fix as well?
> 
> As Yury said in comment 9, we'd rather avoid that and instead wait a little
> longer until we've landed a good solution for this upstream.

I didn't get that from comment 9. We can backout and keep this bug open to track relanding once a proper fix is ready. If this is expected to take more than a few days to fix, I think it's preferable to backout of m-c as well.
Priority: -- → P1
Whiteboard: [pdfjs-c-integration]
QA Whiteboard: [good first verify]
Jonas can you land something for this regression before Monday so that we don't carry this into aurora? If there isn't time to refactor it, we should probably back this out.
Flags: needinfo?(jonas.jenwald)
This will be fixed on mozilla-central as part of bug 1148192.
Flags: needinfo?(jonas.jenwald)
Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: leave-open
Resolution: --- → FIXED
Marking as fixed for 39 based on target milestone for bug 1148192. Untracking.
I have reproduce this bug on Firefox 37.0 (23-02-2015) 

I have successfully tested the fix in these builds and the fix works : 

Firefox Beta 39.0   build id : 20150609130336 User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:39.0) Gecko/20100101 Firefox/39.0
Firefox  Aurora 40.0a2 build id : 20150609081918 User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:40.0) Gecko/20100101 Firefox/40.0
Firefox Nightly 41.0a1 build id : 20150609081916 User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:41.0) Gecko/20100101 Firefox/41.0 

[bugday-2015-06-10]
I have reproduced this bug with Nightly 39.0a1 (2015-02-23) with instruction from comment 0 and Linux x64.

Verified as fixed with latest Nightly 41.0a1 (2015-06-09) (Build ID: 20150609081916), 
Firefox Aurora 40.0a2 (2015-06-10) (Build ID: 20150610004004) and 
Firefox Beta 39.0b4 (Build ID: 20150609130336)

Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
Mozilla/5.0 (X11; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0
Mozilla/5.0 (X11; Linux x86_64; rv:39.0) Gecko/20100101 Firefox/39.0

[bugday-2015-06-10]
As per Comment 22 and Comment 23, Changing the status as verified!
Status: RESOLVED → VERIFIED
QA Whiteboard: [good first verify] → [good first verify][bugday-20150610]
Whiteboard: [pdfjs-c-integration] → [pdfjs-c-integration][bugday-20150610]
Ikram, please make sure the correct flags are set to verified. In this case the fix was verified on Firefox 39, 40 and 41. It's no problem if the flags for 37 & 38 remain as "fixed" 

Otherwise, great job guys... keep it up!
You need to log in before you can comment on or make changes to this bug.