1139021 - Don't do extra GCs and CCs in Mochitest browser tests

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Andrew McCreight [:mccr8]]

Bug 1073352 made us do twice as many GCs and CCs at the end of tests in the parent process.  Ryan noticed that we're hitting more timeouts in the browser chrome tests, which may be related.  Additionally, I've investigated some e10s DOMWINDOW leaks in the parent process, and they are just showing up because we asynchronously do the collection stuff, before the child finishes, but we really need to clean up the child.

This slightly cheesy patch makes ShutdownLeaksCollector not do anything in the parent process.  Instead, we print out the "Completed ShutdownLeaks collections in process" message right before we print out "TEST-START | Shutdown" to match the current behavior.

This doesn't really seem to improve any of the overall Linux32 times, but maybe it will help with individual tests that create a bunch of windows, and thus have a ton of junk at the end.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Don't run extra collections in the parent process for the mochitest window leak detector.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a392f165d89e

Comment 2

[Andrew McCreight [:mccr8]]

Comment on attachment 8572056 [details] [diff] [review]
Don't run extra collections in the parent process for the mochitest window leak detector.

Oops, I forgot to flag this for review.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8572056 [details] [diff] [review]
Don't run extra collections in the parent process for the mochitest window leak detector.

Review of attachment 8572056 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Don't run extra collections in the parent process for the mochitest window leak detector.

Test, just ignore..

Comment 5

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0d72ca21cb7

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d0d72ca21cb7