1139031 - [RTL][Settings] - The MMS header in Message Settings contains improperly formatted () parenthesis when in RTL

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[Joshua Mitchell (Inactive)]

Attachment: 2015-03-03-15-45-52.png

Description:
The () are improperly formatted changing 'Multimedia Messaging (MMS)' to '(Multimedia Messageing (MMS'


Repro Steps:
1) Update a Flame to 20150303010233
2) Open Settings App
3) Navigate to Messaging Settings

Actual:
Improperly formatted ( )

Expected:
proper format for ( )

Environmental Variables:
Device: Flame Master KK - Nightly - Full Flash - 319mem)
Build ID: 201503030102
Build ID: 20150303010233
Gaia: c8ed1085a67490a1ecd7f275e5de9487e1b93b1d
Gecko: 0b3c520002ad
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0


Repro frequency: 5/5
See attached: screenshot

Comment 1

[Joshua Mitchell (Inactive)]

This also occurs on 2.2 

Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150303002527
Gaia: 3d188c414e30acc392253d5389a42352fcfbc183
Gecko: c89aad487aa5
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Norry.L.F(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15994/

Comment 3

[howie [:howie]]

Triage: blocking

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] EragonJ:bug-1139031 > mozilla-b2g:master

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8574496 [details] [review]
[gaia] EragonJ:bug-1139031 > mozilla-b2g:master

Stas, I think this bug has the same issue with the one we fixed in hotspot page, so I follow the same way to fix it, what do you think ?

Thanks ;)

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8574496 [details] [review]
[gaia] EragonJ:bug-1139031 > mozilla-b2g:master

It seems that :Stats is on vacation, so Arthur, can you directly give it a review ? thanks

Comment 7

[Staś Małolepszy :stas]

Comment on attachment 8574496 [details] [review]
[gaia] EragonJ:bug-1139031 > mozilla-b2g:master

I commented in the pull request.  I'd like to see this written in a different manner and also I think it's more prudent to include LRE and PDF in the en-US copy as it may be used in RTL layouts if the translation is not available.

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Staś Małolepszy :stas from comment #7)
> Comment on attachment 8574496 [details] [review]
> [gaia] EragonJ:bug-1139031 > mozilla-b2g:master
> 
> I commented in the pull request.  I'd like to see this written in a
> different manner and also I think it's more prudent to include LRE and PDF
> in the en-US copy as it may be used in RTL layouts if the translation is not
> available.

Stats, what you mean "I'd like to see this written in a different manner" ? Is this what you mean if there is no translation in RTL languages, we will use LTR translation ? If so, I did update the PR and please help me check it when you have time, if not, can you explain explicitly about this ? Thanks :))

Comment 9

[Staś Małolepszy :stas]

Yes, when a translation is missing we fall back to GAIA_DEFAULT_LOCALE which in most builds is en-US.

Comment 10

[Staś Małolepszy :stas]

Comment on attachment 8574496 [details] [review]
[gaia] EragonJ:bug-1139031 > mozilla-b2g:master

The updated pull request looks good, thanks EJ.  Just one small nit which I left on github.

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks Stas ! This patch was merged into Gaia/master : https://github.com/mozilla-b2g/gaia/commit/6b5de6ffb10de6a70a0d6001e69cd7b8ef23a3e3

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8574496 [details] [review]
[gaia] EragonJ:bug-1139031 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): no
[User impact] if declined: For users using RTL languages, they will see weird strings with broken "()" around them.
[Testing completed]: no, only one-line l10 change
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: yes, only one-line.

Comment 13

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Note: For QA who wants to verify this bug, please make sure related strings are updated under http://hg.mozilla.org/gaia-l10n when testing. Thanks !

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/f192b59d7eb16a92f39ee5010e9c667f3fb36e3f

Comment 15

[Norry.L.F(Leave from Mozilla)]

Attachment: VerifyFail_v2.2.png

Hi EJ Chen,
This bug is verifyed successfully on master, but verifyed to fail on v2.2, could you help to check. thanks.

STR:
1) Open Settings App
2) Navigate to Messaging Settings

Attached: VerifyPass_master.png & VerifyFail_v2.2.png

Flame 3.0(Pass):
Build ID               20150312160232
Gaia Revision          eabe35cf054d47087b37c1ca7db8143717fbd7f3
Gaia Date              2015-03-12 18:01:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/42afc7ef5ccb
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150312.194521
Firmware Date          Thu Mar 12 19:45:32 EDT 2015
Bootloader             L1TC000118D0
---------------
FLame 2.2(Fail):
Build ID               20150312002501
Gaia Revision          572d60e0a440ee4af50bc6b6adad8876eadbdb4d
Gaia Date              2015-03-12 01:29:41
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/244e6ba3c20e
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150312.040315
Firmware Date          Thu Mar 12 04:03:26 EDT 2015
Bootloader             L1TC000118D0

Comment 16

[Norry.L.F(Leave from Mozilla)]

Attachment: VerifyPass_master.png

Comment 17

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to EJ Chen [:eragonj][:小龍哥][ni? if you need me] from comment #13)
> Note: For QA who wants to verify this bug, please make sure related strings
> are updated under http://hg.mozilla.org/gaia-l10n when testing. Thanks !

I did leave this comment above for QA to make sure that this bug can only be verified after l10n team does update their localization files.

Please wait with patient when related locales are all updated. Thanks.

Comment 18

[Lancy(Leave from Mozilla)]

Attachment: Verify_parenthesis_Flame2.2_Pass.png

This issue has been verified successfully on latest Flame 2.2 build.
See attachment:Verify_parenthesis_Flame2.2_Pass.png
Reproducing rate:0/10

Flame 2.2 build:
Build ID               20150315162500
Gaia Revision          a6b2d3f8478ec250beb49950fecbb8a16465ff6f
Gaia Date              2015-03-15 14:33:22
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/18619f8f6c5c
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150315.195030
Firmware Date          Sun Mar 15 19:50:42 EDT 2015
Bootloader             L1TC000118D0