1139135 - Feature request: Mach should fail early on Win32.

Status: RESOLVED INVALID

(Firefox Build System :: General, enhancement)

Description

[Mike Hoye [:mhoye]]

Per Bug 1137346 we can no longer build on 32 bit Windows (possibly single-CPU?) Windows systems.

I propose that as soon as mach figures out it's running on Win32 - ideally as close to the start of the build process as possible - that it bail out immediately with an explanation rather than wait (possibly for hours) until we fail at the linker stage.

Comment 1

[Bob Clary [:bc] (inactive)]

I can still build on win32 Windows 7 with dual cpus. Please don't totally kill the possibility of building on win32.

Comment 2

[Mike Hoye [:mhoye]]

OK, add a --force-win32-build option too maybe

Comment 3

[Gregory Szorc [:gps]]

The proper place for this is a configure check.

Comment 4

[(not currently active) Ted Mielczarek]

We could stick a test in here:
https://hg.mozilla.org/mozilla-central/annotate/0189941a3fd5/configure.in#l1866 (where we're already checking that the host system is windows), something like:
if test "$PROCESSOR_ARCHITECTURE" = "x86" -a -z "$PROCESSOR_ARCHITEW6432"; then
  AC_MSG_ERROR([Building on 32-bit Windows is not supported.])
fi

Comment 5

[Mike Hoye [:mhoye]]

OK, I'm going to call this a good first bug and shop it around.

Comment 6

[Jayati Shrivastava]

Hello, Is this bug still valid? Which file should I put the check in ?

Comment 7

[Mike Hoye [:mhoye]]

Sorry, Jayati - this bug should have been closed some time ago. It dates to a time when it was not possible to build on Win32 because of a linker memory problem, but that bug has been resolved. Please find us on Matrix, so we can find you something to work on though! Thank you for your interest.