Closed
Bug 1139158
Opened 9 years ago
Closed 9 years ago
Actions should be available via marionette_driver object
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: njpark, Assigned: bkudryavtsev, Mentored)
Details
(Whiteboard: [lang=py][good first bug])
Attachments
(1 file, 1 obsolete file)
948 bytes,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
Currently, Actions object is residing in marionette_driver.marionette. So the proper import statement is from marionette_driver.marionette import Actions This should be changed so Actions can be discovered within marionette_driver, along with By, Wait, expected. The import statement should be from marionette_driver import Actions OR from marionette_driver.marionette import Actions,By,Wait,expected
Updated•9 years ago
|
Mentor: dburns
Whiteboard: [lang=py][good first bug]
Assignee | ||
Comment 1•9 years ago
|
||
I would like to work on this bug. Can you assign it to me please?
Comment 2•9 years ago
|
||
Assigned. https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver/marionette_driver/__init__.py will need to have all the module changes added to it. Only added, we dont want to remove anything in this patch so that we maintain backwards compatibility for now
Assignee: nobody → boriskk.work
Assignee | ||
Comment 3•9 years ago
|
||
Should the actions class reside in its own file?
Comment 4•9 years ago
|
||
no, I dont think it warrants its own class, at least for now
Assignee | ||
Comment 5•9 years ago
|
||
Importing Actions can be done with from marionette import Actions I am not sure how to make Actions discoverable from marionette_driver without placing it in its own class.
Comment 6•9 years ago
|
||
we need to add `from marionette_driver.marionette import Actions` to the __init__.py shown below https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver/marionette_driver/__init__.py The end result we want is to not do > from marionette_driver.marionette import Actions but rather > from marionette_driver import Actions
Assignee | ||
Comment 7•9 years ago
|
||
Oh. Thanks for the clarification, will do.
Assignee | ||
Comment 8•9 years ago
|
||
Attachment #8584911 -
Flags: review?(jgriffin)
Comment 9•9 years ago
|
||
Comment on attachment 8584911 [details] [diff] [review] rev1 - bug1139158_marionetteimportchanges.diff Review of attachment 8584911 [details] [diff] [review]: ----------------------------------------------------------------- Thanks; can you add ", r=jgriffin" to your commit message? That's needed in order to land this.
Attachment #8584911 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 10•9 years ago
|
||
Attachment #8584911 -
Attachment is obsolete: true
Attachment #8585806 -
Flags: review?(jgriffin)
Comment 11•9 years ago
|
||
Thanks. Running through try for safety's sake: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e4309218ffc
Comment 12•9 years ago
|
||
Comment on attachment 8585806 [details] [diff] [review] rev2 - bug1139158_marionetteimportchanges.diff Review of attachment 8585806 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks!
Attachment #8585806 -
Flags: review?(jgriffin) → review+
Updated•9 years ago
|
Keywords: checkin-needed
Comment 13•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f0ae3378496 Thanks for the patch!
Keywords: checkin-needed
Comment 14•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7f0ae3378496
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•