1139158 - Actions should be available via marionette_driver object

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[No-Jun Park [:njpark]]

Currently, Actions object is residing in marionette_driver.marionette. So the proper import statement is
from marionette_driver.marionette import Actions

This should be changed so Actions can be discovered within marionette_driver, along with By, Wait, expected.  The import statement should be 
from marionette_driver import Actions OR
from marionette_driver.marionette import Actions,By,Wait,expected

Comment 1

[Boris Kudryavtsev [:bkudryavtsev]]

I would like to work on this bug. Can you assign it to me please?

Comment 2

[David Burns :automatedtester]

Assigned.

https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver/marionette_driver/__init__.py will need to have all the module changes added to it. Only added, we dont want to remove anything in this patch so that we maintain backwards compatibility for now

Comment 3

[Boris Kudryavtsev [:bkudryavtsev]]

Should the actions class reside in its own file?

Comment 4

[David Burns :automatedtester]

no, I dont think it warrants its own class, at least for now

Comment 5

[Boris Kudryavtsev [:bkudryavtsev]]

Importing Actions can be done with
from marionette import Actions

I am not sure how to make Actions discoverable from marionette_driver without placing it in its own class.

Comment 6

[David Burns :automatedtester]

we need to add `from marionette_driver.marionette import Actions` to the __init__.py shown below

https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver/marionette_driver/__init__.py

The end result we want is to not do 

> from marionette_driver.marionette import Actions

but rather

> from marionette_driver import Actions

Comment 7

[Boris Kudryavtsev [:bkudryavtsev]]

Oh. Thanks for the clarification, will do.

Comment 8

[Boris Kudryavtsev [:bkudryavtsev]]

Attachment: rev1 - bug1139158_marionetteimportchanges.diff

Comment 9

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8584911 [details] [diff] [review]
rev1 - bug1139158_marionetteimportchanges.diff

Review of attachment 8584911 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks; can you add ", r=jgriffin" to your commit message?  That's needed in order to land this.

Comment 10

[Boris Kudryavtsev [:bkudryavtsev]]

Attachment: rev2 - bug1139158_marionetteimportchanges.diff

Comment 11

[Jonathan Griffin (:jgriffin)]

Thanks.  Running through try for safety's sake:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e4309218ffc

Comment 12

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8585806 [details] [diff] [review]
rev2 - bug1139158_marionetteimportchanges.diff

Review of attachment 8585806 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f0ae3378496

Thanks for the patch!

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7f0ae3378496