1139173 - build with musl libc fails in ipc/chromium/src/base/file_util.h: fts.h: no such file or directory

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Felix Janda]

Build fails on linux systems with musl libc (http://musl-libc.org) in ipc/chromium/src/base/file_util.h because musl lacks fts.h.

Comment 1

[Felix Janda]

Attachment: Remove ScopedTempDir and recursive file_util functions

Bugs 1113463 and 1114753 have indicated to me that a lot of the code is actually unused. Grepping the full tree for ScopedTempDir turned up nothing. With ScopedTempDir removed, file_utils doesn't need to be able to do recursive delete any more.

Comment 2

[Felix Janda]

Attachment: Grep for file_util:: on the tree

It looks like that even more of file_util could be removed.

Comment 3

[Felix Janda]

Comment on attachment 8572209 [details] [diff] [review]
Remove ScopedTempDir and recursive file_util functions

Sorry for the large patch. I could split it into one patch removing ScopedTempDir and a patch for the rest.

Does the approach make sense?

The patch also changes the non-standard (and on musl non-existing) <sys/errno.h> to <errno.h>. Should this be split off?

Since I don't have access to the try server, I could only test on my system.

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8572209 [details] [diff] [review]
Remove ScopedTempDir and recursive file_util functions

Review of attachment 8572209 [details] [diff] [review]:
-----------------------------------------------------------------

This all looks reasonable from a quick skim.  I would prefer the patch to be split up into three patches:

1. Switch to <errno.h>.
2. Remove ScopedTempDir.
3. Cleanup.

Thanks for doing this!

Comment 5

[Felix Janda]

Attachment: Patch 1: <sys/errno.h> -> <errno.h>

Comment 6

[Felix Janda]

Attachment: Patch 2: Remove ScopedTempDir

Comment 7

[Felix Janda]

Attachment: Patch 3: Remove functions depending on <fts.h>

This is the most non-trivial patch.

As can be seen from the changes to file_util.h, the changes are the following:
* Remove the unused CopyDirectory() functions
* Remove the unused recursive argument of Delete()

Comment 8

[Nathan Froyd [:froydnj]]

Thanks for splitting those patches up!

Comment 9

[Felix Janda]

Thanks for the review!

Could you do a try run for me? I don't have access to the try server.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=96ec98c90a00

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/62325b792c42
https://hg.mozilla.org/integration/fx-team/rev/1e75c69141ca
https://hg.mozilla.org/integration/fx-team/rev/9b6b694dd82e

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/62325b792c42
https://hg.mozilla.org/mozilla-central/rev/1e75c69141ca
https://hg.mozilla.org/mozilla-central/rev/9b6b694dd82e