Closed Bug 1139211 Opened 10 years ago Closed 10 years ago

datalist suggested when it's disabled.

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
Other
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: mantaroh, Assigned: mantaroh)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

1139211.patch
1.83 KB, patch
wesj
: review+
Margaret
: review+
Details | Diff | Splinter Review
I submitted patch bug #1130614. But I found another bug. It is that datalist which disabled suggested list from search-suggestions. Reproduce step is 1) access bug 1130614 's attachment file.[1] 2) tap disabled datalist element. actual result: datalist suggested list. Expected result: It should not to show suggestion. It would fix to add disabled check when display suggestions[2] like bug 1130614. I will make patch if it is correct. [1]https://bug720050.bugzilla.mozilla.org/attachment.cgi?id=590393 [2]http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#5835
Flags: needinfo?(wjohnston)
Attached patch 1139211.patch (obsolete) — — Splinter Review
Hi wesj. I created the patch. I modified above comment way. Could you please confirm this patch?
Flags: needinfo?(wjohnston)
Attachment #8573001 - Flags: review?(wjohnston)
Attached patch 1139211.patch — — Splinter Review
Hi wesj, I'm sorry for my mistake that 'r=' name is wrong in my patch.
Attachment #8573001 - Attachment is obsolete: true
Attachment #8573001 - Flags: review?(wjohnston)
Flags: needinfo?(wjohnston)
Attachment #8573145 - Flags: review?(wjohnston)
Assignee: nobody → mantaroh
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 8573145 [details] [diff] [review] 1139211.patch Review of attachment 8573145 [details] [diff] [review]: ----------------------------------------------------------------- I'm sorry. I didn't see this go by. It looks right, but I know this code has changed a lot. Might need rebased?
Attachment #8573145 - Flags: review?(wjohnston) → review+
Comment on attachment 8573145 [details] [diff] [review] 1139211.patch Again, margaret should probably verify this (no device to test right now).
Flags: needinfo?(wjohnston)
Attachment #8573145 - Flags: review?(margaret.leibovic)
Comment on attachment 8573145 [details] [diff] [review] 1139211.patch I verified this fixes the issue. Thanks!
Attachment #8573145 - Flags: review?(margaret.leibovic) → review+
wesj, margret, Thank you for your confirmation!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0ca64dd017ea
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: