Closed
Bug 1139217
Opened 9 years ago
Closed 9 years ago
js::HashSet<T> should work with move-only T types
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file)
|
2.61 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
Right now, due to const-ness, it only invokes copy ctors. We need to remove the const when changing table size to enable moves.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8572316 -
Flags: review?(luke)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8572316 [details] [diff] [review] Make js::HashSet<T> work with move-only T types Ah, all our in-tree uses of non-copyable Ts use HashMaps atm which don't have this problem.
Attachment #8572316 -
Flags: review?(luke) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7df102dceab3
|
|
Assignee | |
Comment 4•9 years ago
|
||
11:55 < RyanVM|sheriffduty> fitzgen|gdc: they're dying before the build even starts, so that seems pretty infra to me -------------------------------------------------------- Alright then!
Keywords: checkin-needed
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/49930e207539
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/49930e207539
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•