1139239 - [Search] Yahoo search result page does not appear with rocket bar search

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Yeojin Chung [:YeojinC]]

Attachment: logcat_20150303_Yahoo.txt

Description:
When Yahoo is set as the default search engine, the Yahoo search result page in Browser does not appear when the user types a keyword in the rocket bar. Instead, the main Yahoo page appears with the keyword filled in.

Repro Steps:
1) Update a Flame to 20150303010233.
2) Go to Settings > Search, and set Yahoo as search engine.
3) Tap the rocket bar, and enter any word.
4) Select any item listed under "YAHOO SEARCH", or press the search icon on the keyboard.

Actual:
Yahoo main screen appears with the search field filled with the typed word.

Expected:
Yahoo search result screen appears.

Environmental Variables:
Device: Flame 3.0 (KK, 319mb, full flash)
Build ID: 20150303010233
Gaia: c8ed1085a67490a1ecd7f275e5de9487e1b93b1d
Gecko: 0b3c520002ad
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Repro frequency: 5/5
See attached: logcat, video
http://youtu.be/gH9aIuyU8fg

Comment 1

[Yeojin Chung [:YeojinC]]

This issue does NOT reproduce on Flame 2.2.

Result: The Yahoo search result page appears on Browser.

Device: Flame 2.2 (KK, 319mb, full flash)
BuildID: 20150303002527
Gaia: 3d188c414e30acc392253d5389a42352fcfbc183
Gecko: c89aad487aa5
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Gregor Wagner [:gwagner]]

Dale, Ben, can you take a look?

Comment 3

[Dale Harvey (:daleharvey)]

Yeh will take, cheers

Comment 4

[Dale Harvey (:daleharvey)]

Picked up the wrong url from http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/searchplugins/yahoo.xml?force=1

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] daleharvey:1139239 > mozilla-b2g:master

Comment 6

[Dale Harvey (:daleharvey)]

Comment on attachment 8572555 [details] [review]
[gaia] daleharvey:1139239 > mozilla-b2g:master

Picks up the correct url from http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/searchplugins/yahoo.xml?force=1

I added a version to the json file, I dont like the duplication but its far better than having the version duplicated and needing to be updated in every test file that needs to configure providers. 

I think we should look at removing it in a follow up but not block fixing the yahoo fix on it.

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8572555 [details] [review]
[gaia] daleharvey:1139239 > mozilla-b2g:master

Seems fine to me, though I think we might just want to hard code the version inside the test support file instead?

Comment 8

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

Nominating 3.0? since Yahoo is a key partner and search is not functioning properly compared to the other search engines.

Comment 9

[Dale Harvey (:daleharvey)]

Cheers Kevin, updated to address comments, good catch

Green try @ https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=cc6644e7e036
Landed in https://github.com/mozilla-b2g/gaia/commit/0017f2bbc63781a5409644b664d80ebaa1543653

Comment 10

[Dale Harvey (:daleharvey)]

Comment on attachment 8572555 [details] [review]
[gaia] daleharvey:1139239 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): New Feature bug
[User impact] if declined: Key search partner misconfigured
[Testing completed]: Manual verification of URL
[Risk to taking this patch] (and alternatives if risky): little risk
[String changes made]: none

Comment 11

[bhavana bajaj [:bajaj]]

ktucker, can we please verify this on 3.0? thanks!

Comment 12

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue is verified as fixed on Flame 3.0

Performing a search with Yahoo set as the default search provider works as expected. The user is shown the actual search results.

Environmental Variables:
Device: Flame 3.0(Full Flash)(KK)(319mb)
BuildID: 20150309010232
Gaia: fea83511df9ccba64259346bc02ebf2c417a12c2
Gecko: eab4a81e4457
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 14

[Dale Harvey (:daleharvey)]

Not sure why this was set as 2.2 unnaffected, has approval so uplifted to 2.2

https://github.com/mozilla-b2g/gaia/commit/bb2afb1a183deaa5fd6a86e5bdcd4e21f785a0c0

Comment 15

[Hermes Cheng (inactive after July 27, 2015)]

Verifed with below build, thanks!

Build ID               20150329162502
Gaia Revision          473cd63f53c855299b719285d9b95e3f2910782f
Gaia Date              2015-03-27 20:14:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4b13c4254e2f
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150329.200030
Firmware Date          Sun Mar 29 20:00:41 EDT 2015
Bootloader             L1TC000118D0

Comment 16

[Shally Li（leave from Mozilla）]

Per Comment 12 & Comment 15 ,clear "verifyme".