1139298 - Replace the type of |aStatus| in BluetoothGattManager callbacks with a new enum BluetoothGattStatus

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Ben Tian (inactive)]

BluetoothGattManager uses int for all |aStatus| in callbacks, however we should replace with BluetoothStatus instead.

Comment 1

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: Bug 1139298: Replace type int with BluetoothGattStatus enum for GATT client callbacks.

Comment 2

[Jocelyn Liu [:jocelyn] [:joliu]]

Comment on attachment 8572503 [details] [diff] [review]
Bug 1139298: Replace type int with BluetoothGattStatus enum for GATT client callbacks.

Hi Ben,

This patch add a new BluetoothGattStatus enum and use it for all GATT statuses reported by bluedroid stack.
Please help to review my patch.

Thanks,
Jocelyn

Comment 3

[Ben Tian (inactive)]

Comment on attachment 8572503 [details] [diff] [review]
Bug 1139298: Replace type int with BluetoothGattStatus enum for GATT client callbacks.

Review of attachment 8572503 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed.

::: dom/bluetooth2/bluedroid/BluetoothGattHALInterface.cpp
@@ +133,5 @@
>  
>    typedef BluetoothNotificationHALRunnable5<
>      GattClientNotificationHandlerWrapper, void,
> +    int, BluetoothGattStatus, BluetoothGattServiceId, BluetoothGattId, int,
> +    int, BluetoothGattStatus, const BluetoothGattServiceId&, const BluetoothGattId&>

nit: this line is too long (> 80 characters).

Comment 4

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: [Final] Bug 1139298: Replace type int with BluetoothGattStatus enum for GATT client callbacks. r=btian

Thanks for your time, Ben.

Comment 5

[Jocelyn Liu [:jocelyn] [:joliu]]

No try server link since bluetooth2 won't be built.

Comment 6

[Ben Tian (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/37af0c11452b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/37af0c11452b