Closed
Bug 1139298
Opened 9 years ago
Closed 9 years ago
Replace the type of |aStatus| in BluetoothGattManager callbacks with a new enum BluetoothGattStatus
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(firefox39 fixed)
RESOLVED
FIXED
2.2 S7 (6mar)
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: ben.tian, Assigned: yrliou)
References
Details
(Whiteboard: [webbt-api])
Attachments
(1 file, 1 obsolete file)
BluetoothGattManager uses int for all |aStatus| in callbacks, however we should replace with BluetoothStatus instead.
Reporter | ||
Updated•9 years ago
|
Whiteboard: [webbt-api]
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → joliu
Summary: Replace typeof |aStatus| in BluetoothGattManager callbacks with |BluetoothStatus| → Replace the type of |aStatus| in BluetoothGattManager callbacks with a new enum BluetoothGattStatus
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8572503 [details] [diff] [review] Bug 1139298: Replace type int with BluetoothGattStatus enum for GATT client callbacks. Hi Ben, This patch add a new BluetoothGattStatus enum and use it for all GATT statuses reported by bluedroid stack. Please help to review my patch. Thanks, Jocelyn
Attachment #8572503 -
Flags: review?(btian)
Reporter | ||
Comment 3•9 years ago
|
||
Comment on attachment 8572503 [details] [diff] [review] Bug 1139298: Replace type int with BluetoothGattStatus enum for GATT client callbacks. Review of attachment 8572503 [details] [diff] [review]: ----------------------------------------------------------------- r=me with nit addressed. ::: dom/bluetooth2/bluedroid/BluetoothGattHALInterface.cpp @@ +133,5 @@ > > typedef BluetoothNotificationHALRunnable5< > GattClientNotificationHandlerWrapper, void, > + int, BluetoothGattStatus, BluetoothGattServiceId, BluetoothGattId, int, > + int, BluetoothGattStatus, const BluetoothGattServiceId&, const BluetoothGattId&> nit: this line is too long (> 80 characters).
Attachment #8572503 -
Flags: review?(btian) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Thanks for your time, Ben.
Attachment #8572503 -
Attachment is obsolete: true
Assignee | ||
Comment 5•9 years ago
|
||
No try server link since bluetooth2 won't be built.
Keywords: checkin-needed
Reporter | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/37af0c11452b
Keywords: checkin-needed
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/37af0c11452b
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S7 (6mar)
You need to log in
before you can comment on or make changes to this bug.
Description
•