1139316 - [EME] Add pref to enable EME outside of MSE

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

I realised that most of Adobe's testing to date has been with non-MSE video. So our decision to disable EME outside of MSE, will break all their testing. We should add a pref so that Adobe can still test while they transition to MSE.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Add pref to enable EME outside of MSE

Add pref to enable EME outside of MSE.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f369b1abdc2

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Must uplift.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2f369b1abdc2

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8572526 [details] [diff] [review]
Patch: Add pref to enable EME outside of MSE

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: This only impacts Adobe. We have disabled EME in non-MSE video, however most of Adobe's testing has been done with non-MSE video, so this patch adds a pref so at least they can keep testing until they get the time to migrate their tests over to MSE.
[Describe test coverage new/current, TreeHerder]: Local testing only, we don't want to maintain the codepath that this pref enables; this is a stopgap measure so that Adobe's schedule is not adversely affected.
[Risks and why]: Low, it's a pretty trivial change.
[String/UUID change made/needed]: None

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/83db950282b4

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

I see the conditions that check for the media.eme.mse-only pref bug don't see where we set this pref by default in the product. Is the pref set in another patch? Am I missing something?

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5aff376f9bec

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8572526 [details] [diff] [review]
Patch: Add pref to enable EME outside of MSE

Review of attachment 8572526 [details] [diff] [review]:
-----------------------------------------------------------------

Not needed for Beta. Still needed for Aurora 38.