Closed Bug 1139316 Opened 5 years ago Closed 5 years ago

[EME] Add pref to enable EME outside of MSE

Categories

(Core :: Audio/Video, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox37 --- wontfix
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I realised that most of Adobe's testing to date has been with non-MSE video. So our decision to disable EME outside of MSE, will break all their testing. We should add a pref so that Adobe can still test while they transition to MSE.
Add pref to enable EME outside of MSE.
Attachment #8572526 - Flags: review?(edwin)
Must uplift.
Flags: needinfo?(cpearce)
https://hg.mozilla.org/mozilla-central/rev/2f369b1abdc2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Comment on attachment 8572526 [details] [diff] [review]
Patch: Add pref to enable EME outside of MSE

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: This only impacts Adobe. We have disabled EME in non-MSE video, however most of Adobe's testing has been done with non-MSE video, so this patch adds a pref so at least they can keep testing until they get the time to migrate their tests over to MSE.
[Describe test coverage new/current, TreeHerder]: Local testing only, we don't want to maintain the codepath that this pref enables; this is a stopgap measure so that Adobe's schedule is not adversely affected.
[Risks and why]: Low, it's a pretty trivial change.
[String/UUID change made/needed]: None
Attachment #8572526 - Flags: approval-mozilla-beta?
Attachment #8572526 - Flags: approval-mozilla-aurora?
I see the conditions that check for the media.eme.mse-only pref bug don't see where we set this pref by default in the product. Is the pref set in another patch? Am I missing something?
Flags: needinfo?(cpearce)
Comment on attachment 8572526 [details] [diff] [review]
Patch: Add pref to enable EME outside of MSE

Review of attachment 8572526 [details] [diff] [review]:
-----------------------------------------------------------------

Not needed for Beta. Still needed for Aurora 38.
Attachment #8572526 - Flags: approval-mozilla-beta?
Attachment #8572526 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.