1139337 - Shortcut commands from menu panel are not visible on hover with High Contrast themes

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Note: this is a follow-up for Bug 1079098

Reproducible on: 
Firefox 39.0a1 on Windows 8.1 64bit

STR
1.Right click on desktop -> Personalize.
2.Select High Contrast Black (or High Contrast White)
3.Launch Firefox with clean profile.
4.Click on Menu Panel.
5.Open Web Development Tools.
6.Hover over one of the tools from the list.

AR
The shortcut commands are not visible on hover.

ER 
The shortcut commands are clearly visible on hover.

Additional notes:
 - This issue is reproducible on Firefox 39.0a1 (2015-03-03) using Windows 8.1 64bit with High Contrast Black and High Contrast White
 - I am attaching 2 screenshots:
	 High Contrast Black:	http://i.imgur.com/9tdvr7g.jpg
	 High Contrast White: 	http://i.imgur.com/nGsgQLX.jpg

Comment 1

[Richard Marti (:Paenglab)]

Attachment: shortcutHover.patch

This sets also for the shortcut the highlight color on hover.

Comment 2

[:Gijs (he/him)]

... and I was planning to land this straight away, but fx-team is closed. :-\

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/d6580fa1125f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d6580fa1125f

Comment 5

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 39.0a1 (2015-03-04) using Windows 8.1 x64.

Verified fixed on Firefox 39.0a1 (2015-03-08) using Windows 8.1 x64 with High Contrast Black and High Contrast White.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 38 based on comments in bug 1079098.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8573490 [details] [diff] [review]
shortcutHover.patch

[Triage Comment]

Approving this for uplift to 38 since it goes with the second patch in bug 1079098, based on https://bugzilla.mozilla.org/show_bug.cgi?id=1079098#c39

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d982b2490a53

Comment 9

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 38.0a2 (2015-03-16) using Windows 8.1 32bit.

Verified fixed on Firefox 38.0a2 (2015-03-18) using Windows 8.1 32bit with High Contrast Black and High Contrast White.