1139363 - Get rid of Notification.onclose and Notification.onshow events

Status: NEW

(Core :: DOM: Core & HTML, task, P5)

Description

[Oleg Zasypkin [:azasypkin]]

Recently "onclose" and "onshow" events were removed from Notification API spec - see [1], [2] and [3]. So we should update Gecko implementation as well.

Removing of "onclose" is especially valuable for gaia apps, see bug 1068564 and bug 1136633. 

[1] https://notifications.spec.whatwg.org/
[2] https://lists.w3.org/Archives/Public/public-whatwg-archive/2014Oct/0135.html
[3] https://lists.w3.org/Archives/Public/public-whatwg-archive/2014Oct/0082.html

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Considering they are a part of the w3c spec http://www.w3.org/TR/notifications/#api and are very likely relied upon by developers, we should have a clear deprecation path instead of straight removal. I don't know if we have established processes for this, but at the least the first step is adding deprecation warnings when it is used.

Comment 2

[Julien Wajsberg [:julienw]]

What we _really_ want to remove is the system messages. This should be reasonnably safe to do.

For the onshow/onclose events, I agree.

Comment 3

[James Burke [:jrburke]]

A migration path could be that if the app does not register onclose, do not send the system message, and if they do, onclose would print a deprecation warning but still allow it for a window. Same with onshow. 

That works for the email app, as it does not bind an onclose listener now.

Comment 4

[Julien Wajsberg [:julienw]]

I don't think this is possible currently, given how the notification subsystem works.

Comment 5

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.