1139487 - Remove mozprocess.pid, mozprocess.wpk

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[William Lachance (:wlach)]

These functions are known to be broken (see bug 1138759). For code in mozilla-central, we can just use psutil which is included there (nothing there uses mozprocess.pid right now though). The only other consumer of this code is talos. I'd just copy the relevant code into talos directly. If/when we move talos into mozilla-central, we can migrate it to use psutil as well.

Comment 1

[William Lachance (:wlach)]

Attachment: Remove mozprocess.pid, mozprocess.wpk

This removes these functions from mozprocess.

Comment 2

[William Lachance (:wlach)]

Attachment: Make talos use psutil instead mozprocess.pid

obv this needs a try run, doing one

Comment 3

[William Lachance (:wlach)]

Try run for mozbase unit tests and talos: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e91dfac29c85

Comment 4

[William Lachance (:wlach)]

Unfortunately this approach doesn't work with Windows talos, as it requires compiling some parts of psutil which aren't supported in that environment. I assume this problem has somehow been solved for our other tests (probably by precompiling psutil and putting it in tests.zip), if we ever moved talos in-tree (bug 787200) we would be ok pushing this code. As it is, solving this in alternate ways probably isn't worth the effort. Let's just leave things as they are for now and maybe revisit in the future.

Comment 5

[William Lachance (:wlach)]

Not working on this at the moment.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

ok, psutil is working now, this might be worth revisiting.

Comment 7

[Julien Pagès (:parkouss)]

Attachment: MozReview Request: Bug 1139487 - Remove mozprocess.pid usage from talos. r=jmaher

Bug 1139487 - Remove mozprocess.pid usage from talos. r=jmaher

Comment 8

[Julien Pagès (:parkouss)]

Attachment: MozReview Request: Bug 1139487 - Remove mozprocess.pid, mozprocess.wpk. r=jmaher

Bug 1139487 - Remove mozprocess.pid, mozprocess.wpk. r=jmaher

Comment 9

[Julien Pagès (:parkouss)]

So, let's see how that goes - I ran a push try on the first patch only,

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb30fddb5d69

We should ensure that numbers are still consistent.

I tried with dxr to find all mozprocess.pid, mozprocess.wpk usage - seems to me like talos was alone. But maybe a full push to try would be good here to be sure ?

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8670446 [details]
MozReview Request: Bug 1139487 - Remove mozprocess.pid, mozprocess.wpk. r=jmaher

https://reviewboard.mozilla.org/r/21367/#review19253

this is nice!

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8670445 [details]
MozReview Request: Bug 1139487 - Remove mozprocess.pid usage from talos. r=jmaher

https://reviewboard.mozilla.org/r/21365/#review19255

this is more of a rubber stamp, this change confuses me, not the change, just the code it is in!

Comment 12

[Julien Pagès (:parkouss)]

So, we should be good, looking at talos results there are no obvious changes:

https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-inbound&originalRevision=d01dd42e654b&newProject=try&newRevision=cb30fddb5d69

So I should still run a try on the two patches just to be sure unit tests are good for each platform.

Comment 13

[Julien Pagès (:parkouss)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=51bc43ca702d

Comment 14

[Julien Pagès (:parkouss)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d52d889c77bd25e2ccefcd609570e0b371863d9
Bug 1139487 - Remove mozprocess.pid usage from talos. r=jmaher

https://hg.mozilla.org/integration/mozilla-inbound/rev/c57207f4c801c1af8ded94db984b3fb802e434fc
Bug 1139487 - Remove mozprocess.pid, mozprocess.wpk. r=jmaher

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9d52d889c77b
https://hg.mozilla.org/mozilla-central/rev/c57207f4c801