1139594 - Identity popup class needs close method

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[om.bhallamudi]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/40.0.2214.111 Safari/537.36



Actual results:

The identity popup class of firefox_puppeteer/ui/toolbars.py needs a close method.
The fix is at: https://github.com/mozilla/firefox-ui-tests/pull/105

Comment 1

[om.bhallamudi]

Attachment: bugfix

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8572832 [details] [review]
bugfix

Functionality wise that looks great. Please check existing tests for the usage of the popup and escape, so you can replace that code. Also that the close() method is called with force in tearDown so we explicitly make sure that the popup gets closed. Otherwise just some styling nits.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So who is actually working on this bug? I see PR 105 and PR 115.

Comment 4

[Barbara Miller (:galgeek)]

I've uploaded this PR: https://github.com/mozilla/firefox-ui-tests/pull/124

The code from the earlier PRs fails with a NoSuchElementException when I run it from tearDown in the green Larry test, bug 1132651.

Comment 5

[Barbara Miller (:galgeek)]

I also have a first draft of a unit test ready for this method that I could add here or to the unit tests bug.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As mentioned on the PR the panel should never go away. You can see that by using the DOM inspector and searching for it. So I don't see why we have to check for its existence. An example test would be nice to have so I could also have a look at.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Johannes was that kind to take over this bug.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: github_pull_request.txt

This is the link to his pull request.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

https://github.com/mozilla/firefox-ui-tests/commit/7e8197658e3db01bc259d467cfe7e16967a5075d