1139662 - Internal server error when trying to specify reviewer

Status: RESOLVED DUPLICATE of bug 1169724

(MozReview Graveyard :: General, defect, P1)

Description

[Botond Ballo [:botond]]

I pushed a review request to MozReview for the first time, and in the Reviewboard UI I tried to enter "kats" as a reviewer for the first patch.

I got the following error:

HTTP 500 INTERNAL SERVER ERROR

reportError@https://reviewboard.mozilla.org/static/ext/rbmozui.extension.RBMozUI/js/reviews.min.51540d5625fd.js:1:992
CommitView<.render/<.error@https://reviewboard.mozilla.org/static/ext/rbmozui.extension.RBMozUI/js/reviews.min.51540d5625fd.js:1:6468
request/<.error@https://reviewboard.mozilla.org/static/ext/rbmozui.extension.RBMozUI/js/reviews.min.51540d5625fd.js:1:16887
p.Callbacks/k@https://reviewboard.mozilla.org/static/lib/js/jquery-1.8.2.min.cfa9051cc0b0.js:2:16915
p.Callbacks/l.fireWith@https://reviewboard.mozilla.org/static/lib/js/jquery-1.8.2.min.cfa9051cc0b0.js:2:17707
y@https://reviewboard.mozilla.org/static/lib/js/jquery-1.8.2.min.cfa9051cc0b0.js:2:80827
.send/d@https://reviewboard.mozilla.org/static/lib/js/jquery-1.8.2.min.cfa9051cc0b0.js:2:86374

Please let me know if there is any other information I can provide to help diagnose the issue.

Comment 1

[Botond Ballo [:botond]]

Note that this happens consistently for me every time I specify "kats" as the reviewer (but, interestingly, not other reviewers). However, in spite of the error, "kats" does get saved as the reviewer in the review request.

Comment 2

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Attachment: Screenshot of the error

I got the same error today when specifying a different reviewer.

Stack:

HTTP 500 INTERNAL SERVER ERROR

reportError@https://reviewboard.mozilla.org/static/ext/mozreview.extension.MozReviewExtension/js/reviews.min.87cd9a2050dc.js:1:1006
CommitView<.render/<.error@https://reviewboard.mozilla.org/static/ext/mozreview.extension.MozReviewExtension/js/reviews.min.87cd9a2050dc.js:1:6488
request/<.error@https://reviewboard.mozilla.org/static/ext/mozreview.extension.MozReviewExtension/js/reviews.min.87cd9a2050dc.js:1:16941
p.Callbacks/k@https://reviewboard.mozilla.org/static/lib/js/jquery-1.8.2.min.cfa9051cc0b0.js:2:16915
p.Callbacks/l.fireWith@https://reviewboard.mozilla.org/static/lib/js/jquery-1.8.2.min.cfa9051cc0b0.js:2:17707
y@https://reviewboard.mozilla.org/static/lib/js/jquery-1.8.2.min.cfa9051cc0b0.js:2:80827
.send/d@https://reviewboard.mozilla.org/static/lib/js/jquery-1.8.2.min.cfa9051cc0b0.js:2:86374

Comment 3

[Mark Côté [:mcote]]

We have too many P1s, so I'm spreading out the priorities.  P3 -> P4, P2 -> P3, and some portion of P1s will become P2.

Comment 4

[Mark Côté [:mcote]]

Bumping this up, since this now prevents botond from using the automatic reviewer-setting feature from bug 1142251, as best I can tell.

I see a series of these errors on the server around he submitted review request 9477.  I believe these are from when he manually set the reviewers afterward, but I think it's likely they have the same root cause, just that it's a fatal error in the automatic detection.


 - Exception thrown for user botond at https://reviewboard.mozilla.org/api/users/?q=kats&limit=150&timestamp=1432760641126&fullname=1

not well-formed (invalid token): line 1, column 39791
Traceback (most recent call last):
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/django/core/handlers/base.py", line 112, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib64/python2.6/site-packages/newrelic-2.44.0.36/newrelic/hooks/framework_django.py", line 497, in wrapper
    return wrapped(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/django/views/decorators/cache.py", line 52, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/django/views/decorators/vary.py", line 19, in inner_func
    response = func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.18-py2.6.egg/djblets/webapi/resources.py", line 497, in __call__
    request, method, view, api_format=api_format, *args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.18-py2.6.egg/djblets/webapi/resources.py", line 568, in call_method_view
    return view(request, *args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.18-py2.6.egg/djblets/webapi/decorators.py", line 117, in _call
    return view_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/ReviewBoard-2.0.15-py2.6.egg/reviewboard/webapi/decorators.py", line 110, in _check
    return view_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.18-py2.6.egg/djblets/webapi/decorators.py", line 117, in _call
    return view_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.18-py2.6.egg/djblets/webapi/decorators.py", line 117, in _call
    return view_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.18-py2.6.egg/djblets/webapi/decorators.py", line 287, in _validate
    return view_func(*args, **new_kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/ReviewBoard-2.0.15-py2.6.egg/reviewboard/webapi/resources/user.py", line 162, in get_list
    return super(UserResource, self).get_list(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.18-py2.6.egg/djblets/webapi/decorators.py", line 117, in _call
    return view_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/ReviewBoard-2.0.15-py2.6.egg/reviewboard/webapi/decorators.py", line 33, in _check
    return view_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.18-py2.6.egg/djblets/webapi/decorators.py", line 117, in _call
    return view_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/ReviewBoard-2.0.15-py2.6.egg/reviewboard/webapi/decorators.py", line 110, in _check
    return view_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.18-py2.6.egg/djblets/webapi/decorators.py", line 117, in _call
    return view_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.18-py2.6.egg/djblets/webapi/decorators.py", line 287, in _validate
    return view_func(*args, **new_kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/ReviewBoard-2.0.15-py2.6.egg/reviewboard/webapi/base.py", line 78, in get_list
    return self._get_list_impl(request, *args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/ReviewBoard-2.0.15-py2.6.egg/reviewboard/webapi/base.py", line 93, in _get_list_impl
    return super(WebAPIResource, self).get_list(request, *args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.18-py2.6.egg/djblets/util/decorators.py", line 78, in _call
    f = augmented_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.18-py2.6.egg/djblets/webapi/decorators.py", line 117, in _call
    return view_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.18-py2.6.egg/djblets/webapi/decorators.py", line 117, in _call
    return view_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.18-py2.6.egg/djblets/webapi/decorators.py", line 287, in _validate
    return view_func(*args, **new_kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.18-py2.6.egg/djblets/webapi/resources.py", line 853, in get_list
    *args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.18-py2.6.egg/djblets/webapi/resources.py", line 1361, in _get_queryset
    queryset = self.get_queryset(request, is_list=is_list, *args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/ReviewBoard-2.0.15-py2.6.egg/reviewboard/webapi/resources/user.py", line 56, in get_queryset
    backend.query_users(search_q, request)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/rbbz-0.2.8-py2.6.egg/rbbz/auth.py", line 136, in query_users
    get_or_create_bugzilla_users(bugzilla.query_users(query))
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/rbbz-0.2.8-py2.6.egg/rbbz/bugzilla.py", line 19, in _transform_errors
    return func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/rbbz-0.2.8-py2.6.egg/rbbz/bugzilla.py", line 111, in query_users
    return self.proxy.User.get(params)
  File "/usr/lib64/python2.6/xmlrpclib.py", line 1199, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib64/python2.6/xmlrpclib.py", line 1489, in __request
    verbose=self.__verbose
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/rbbz-0.2.8-py2.6.egg/rbbz/transports.py", line 80, in request
    return self.parse_response(response)
  File "/usr/lib64/python2.6/xmlrpclib.py", line 1361, in parse_response
    return self._parse_response(file, None)
  File "/usr/lib64/python2.6/xmlrpclib.py", line 1387, in _parse_response
    p.feed(response)
  File "/usr/lib64/python2.6/xmlrpclib.py", line 601, in feed
    self._parser.Parse(data, 0)
ExpatError: not well-formed (invalid token): line 1, column 39791

Comment 5

[Mark Côté [:mcote]]

This particular problem is the same as the main one in bug 1169724.  There's also another problem in that bug that I'll file separately.