1139683 - Update SetExistingProperty with comments and references to ES6 algorithm steps

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Rewrite SetExistingProperty with comments and references to the standard

Comment 2

[Jason Orendorff [:jorendorff]]

https://tbpl.mozilla.org/?tree=Try&rev=89d78044a622

Comment 3

[Jason Orendorff [:jorendorff]]

https://tbpl.mozilla.org/?tree=Try&rev=4ff9d8875a92

Comment 4

[Eric Faust [:efaust]]

Comment on attachment 8572926 [details] [diff] [review]
Rewrite SetExistingProperty with comments and references to the standard

Review of attachment 8572926 [details] [diff] [review]:
-----------------------------------------------------------------

You are a braver man than I. Thanks for your continued valiant efforts in this space. r=me

::: js/src/vm/NativeObject.cpp
@@ +2190,4 @@
>              !(pobj->is<ArrayObject>() && id == NameToId(cx->names().length)))
>          {
> +            // Even weirder sub-special-case: inherited slotless data property
> +            // with default setter. Wut.

My sentiments exactly.

Comment 5

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26fd55677841

Comment 6

[Phil Ringnalda (:philor)]

Backed out that whole push in https://hg.mozilla.org/integration/mozilla-inbound/rev/c3638d994edd for massive widespread bustage, https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=7613fc978d36&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception - something must have changed out from under you.

Comment 7

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a25cc961aaf0

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a25cc961aaf0