Closed Bug 1139683 Opened 5 years ago Closed 5 years ago

Update SetExistingProperty with comments and references to ES6 algorithm steps

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Comment on attachment 8572926 [details] [diff] [review]
Rewrite SetExistingProperty with comments and references to the standard

Review of attachment 8572926 [details] [diff] [review]:
-----------------------------------------------------------------

You are a braver man than I. Thanks for your continued valiant efforts in this space. r=me

::: js/src/vm/NativeObject.cpp
@@ +2190,4 @@
>              !(pobj->is<ArrayObject>() && id == NameToId(cx->names().length)))
>          {
> +            // Even weirder sub-special-case: inherited slotless data property
> +            // with default setter. Wut.

My sentiments exactly.
Attachment #8572926 - Flags: review?(efaustbmo) → review+
https://hg.mozilla.org/mozilla-central/rev/a25cc961aaf0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Depends on: 1147655
You need to log in before you can comment on or make changes to this bug.