1139721 - [B2G][Camera][Gecko] Fix memory leaks uncovered by existing automated tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Andrew Osmond [:aosmond] (he/him)]

The following leaks are already caught by the existing unit tests, but the leak check output has gone unnoticed until now:

1) When the camera fails to initialize and the application's CameraManager.getCamera call fails, we never supply a reference to the CameraControl object so the application can not call release. However the only way we presently free the GonkCameraControl object is if CameraControl.release is called. We need to free it automatically.

2) CameraCapabilities does not call MOZ_COUNT_CTOR but does call MOZ_COUNT_DTOR resulting in a bad leak summary.

3) When CameraControl's onfacesdetected event is generated, we add an extra unnecessary reference to each DOMCameraDetectedFace object. Not only do those objects leak, they hold a reference to CameraControl as well which causes many other objects to be held onto.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: bug1139721.patch, v1

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8572972 [details] [diff] [review]
bug1139721.patch, v1

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cfc61a29c3e

Looks like I might have missed something else since the debug emulator crashed in one of our tests but the optimized emulator passed.

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 8572972 [details] [diff] [review]
bug1139721.patch, v1

Review of attachment 8572972 [details] [diff] [review]:
-----------------------------------------------------------------

Good work!

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Attachment: bug1139721.patch, v1.1 [carries r=mikeh]

Fix typo in comment.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=270194578fb6

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/98bc69015608

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/b2g-inbound/rev/355ac9495b03 for being the likely cause of frequent b2g debug mochitest-5 failures:

https://treeherder.mozilla.org/logviewer.html#?job_id=1521747&repo=b2g-inbound

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

Looks like the problem may have been solved or otherwise made unreproducible, because it doesn't happen when I run the camera tests now (in mochitest-6 grouping now), both on the try server and locally (50+ attempts overnight).

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e8fce43dba6

Comment 8

[Andrew Osmond [:aosmond] (he/him)]

Attachment: bug1139721.patch, v1.2 [carries r=mikeh]

Rebase.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/7a458d7e3e4f

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7a458d7e3e4f