1139752 - Fix about:telemetry to work with the unified pings

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Vladan Djeric (:vladan)]

about:telemetry doesn't load because of an exception "TypeError: value is null"

  renderBody: function KeyValueTable_renderBody(aTable, aMeasurements) {
    for (let [key, value] of Iterator(aMeasurements)) {
      // use .valueOf() to unbox Number, String, etc. objects
====> if ((typeof value == "object") && (typeof value.valueOf() == "object")) {
        value = RenderObject(value);
      }

I think this exception occurs when handling the "System Information" section

Comment 1

[Vladan Djeric (:vladan)]

Attachment: aboutTelemetryNull.patch

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8574090 [details] [diff] [review]
aboutTelemetryNull.patch

Review of attachment 8574090 [details] [diff] [review]:
-----------------------------------------------------------------

This definitely makes sense.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/11282d8746ea

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/11282d8746ea