1139805 - B2G NetworkManager: move NetworkManager.js out of EXTRA_PP_COMPONENTS in moz.build

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Jessica Jong [:jessica] (inactive)]

Since we got rid of #ifdefs in NetworkManager, it should no longer be included in EXTRA_PP_COMPONENTS. This will avoid the following warning message when building gecko:
".../gecko/dom/system/gonk/NetworkManager.js: WARNING: no preprocessor directives found"

Comment 1

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v1.

Comment 2

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8573146 [details] [diff] [review]
patch, v1.

Edgar, may I have your review on this? Thanks.

Comment 3

[Edgar Chen [:edgar]]

Comment on attachment 8573146 [details] [diff] [review]
patch, v1.

Review of attachment 8573146 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.

Comment 4

[Jessica Jong [:jessica] (inactive)]

Thank you, Edgar.

try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=681eb7b13bd2

There are some failures, but they are currently marked as known issues in b2g-inbound:
https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=b79a38cf4f65

Comment 5

[Jessica Jong [:jessica] (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/4ab285f088cb

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4ab285f088cb