Closed Bug 1139900 Opened 6 years ago Closed 6 years ago

make tag name based roles faster

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
getting a bit closer to have declarative HTML accessibility implementation
Attachment #8573244 - Flags: review?(mzehe)
I added a map for div to make HyperTextAccessible::NativeRole() nicer

MARKUPMAP(div,
          nullptr,
          roles::SECTION)
Comment on attachment 8573244 [details] [diff] [review]
patch

We can have nice things! :) Thanks!
Attachment #8573244 - Flags: review?(mzehe) → review+
https://hg.mozilla.org/mozilla-central/rev/4a5963623ac5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Comment on attachment 8573244 [details] [diff] [review]
patch

my bet would be this makes things slower, and its certainly harder to read.
it's middle step, we have to move rest markup stuff into those maps, that will fix potential readability issues
(In reply to alexander :surkov from comment #5)
> it's middle step, we have to move rest markup stuff into those maps, that
> will fix potential readability issues

I don't think you'll ever be able to totally do that, and even if you could I'm not convinced it would be particularly readable.
You need to log in before you can comment on or make changes to this bug.