1139956 - Pressing links and controls doesn't highlight them

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

Pressing on in page links doesn't highlight them, so you have to look at the thin blue bar to see if you hit it.  Same for the back/forward pages.

Comment 1

[Aaron Train [:aaronmt]]

Safari and Chrome will link highlight grey, we should do the same

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This is a regression caused by 1109666 - Customize behavior when long-pressing a link. The WKWebView does highlight links correctly but our custom handling of presses seemed to override and kill that.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Confirmed that the LongPressBrowserHelper causes this regression.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/393

This patch disables our own long press gesture recognizer and disables the reading list option in the default WebKit action sheet.

The way this is implemented may look scary but this does not actually use private APIs. It simply uses the dynamic nature of Objective-C. The app store binary validator does not flag this as improper API usage.

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

As a nice side-effect of using the built-in gestures, things like long pressing on a phone number will also work much better. See https://www.dropbox.com/s/z5ubi6pwz4t0fzt/Screenshot%202015-04-28%2016.01.27.png?dl=0

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Merged with r=bnicholson