Closed
Bug 1139964
Opened 9 years ago
Closed 9 years ago
[e10s] Framescripts don't have Promise defined
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
People
(Reporter: mossop, Assigned: bzbarsky)
Details
Attachments
(4 files)
4.22 KB,
patch
|
Details | Diff | Splinter Review | |
5.98 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
4.60 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
5.06 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
The Promise constructor isn't defined in framescripts. It would be useful to have this rather than reverting to Promise.jsm.
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
Is this basically the thing about message manager not using webidl globals? Where are we setting up the relevant global objects? Should they be getting Exposed=System stuff defined on them, perhaps?
Flags: needinfo?(bugs)
Comment 2•9 years ago
|
||
bz said he is looking into implementing this. { hasPromise: ("Promise" in this) } is the part one may need to change.
Flags: needinfo?(bugs)
Comment 3•9 years ago
|
||
That test could be ofc extended to check more properties in the global, but easier to update it after Exposed=System works for mm globals.
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8573443 -
Flags: review?(bugs)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8573444 -
Flags: review?(bugs)
Assignee | ||
Comment 6•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8573445 -
Flags: review+
Updated•9 years ago
|
Attachment #8573443 -
Flags: review?(bugs) → review+
Comment 7•9 years ago
|
||
Comment on attachment 8573444 [details] [diff] [review] part 2. Add classinfo helpers for the various message manager stuff to install WebIDL Exposed=System things on those globals >+nsMessageManagerSH<Super>::Enumerate(nsIXPConnectWrappedNative* wraper, s/wraper/wrapper/ >+ JSContext* cx, JSObject* obj_, >+ bool* _retval) >+{ >+ JS::Rooted<JSObject*> obj(cx, obj_); >+ >+ *_retval = SystemGlobalEnumerate(cx, obj); >+ NS_ENSURE_TRUE(*_retval, NS_ERROR_FAILURE); >+ >+ // Don't call up to our superclass, since neither nsDOMGenericSH nor >+ // nsEventTargetSH have WANT_ENUMERATE. Want to assert here that !(GetScriptableFlags() & nsIXPCScriptable::WANT_ENUMERATE) >+ NS_IMETHOD Enumerate(nsIXPConnectWrappedNative* wraper, JSContext* cx, wraper
Attachment #8573444 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 8•9 years ago
|
||
Made those fixes and: https://hg.mozilla.org/integration/mozilla-inbound/rev/776479701858 https://hg.mozilla.org/integration/mozilla-inbound/rev/0fd6e192a220 https://hg.mozilla.org/integration/mozilla-inbound/rev/8d0293dcec1e
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/776479701858 https://hg.mozilla.org/mozilla-central/rev/0fd6e192a220 https://hg.mozilla.org/mozilla-central/rev/8d0293dcec1e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•