1139964 - [e10s] Framescripts don't have Promise defined

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Dave Townsend [:mossop]]

The Promise constructor isn't defined in framescripts. It would be useful to have this rather than reverting to Promise.jsm.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Is this basically the thing about message manager not using webidl globals?  Where are we setting up the relevant global objects?  Should they be getting Exposed=System stuff defined on them, perhaps?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: wip for the test

bz said he is looking into implementing this.

{ hasPromise: ("Promise" in this) } is the part one may need to change.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

That test could be ofc extended to check more properties in the global, but easier to update it
after Exposed=System works for mm globals.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Factor out the guts of BackstagePass::Resolve and BackstagePass::Enumerate to allow reuse for other globals that want to opt in to Exposed=System WebIDL annotations

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Add classinfo helpers for the various message manager stuff to install WebIDL Exposed=System things on those globals

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Add a test

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8573444 [details] [diff] [review]
part 2.  Add classinfo helpers for the various message manager stuff to install WebIDL Exposed=System things on those globals

>+nsMessageManagerSH<Super>::Enumerate(nsIXPConnectWrappedNative* wraper,
s/wraper/wrapper/

>+                                     JSContext* cx, JSObject* obj_,
>+                                     bool* _retval)
>+{
>+  JS::Rooted<JSObject*> obj(cx, obj_);
>+
>+  *_retval = SystemGlobalEnumerate(cx, obj);
>+  NS_ENSURE_TRUE(*_retval, NS_ERROR_FAILURE);
>+
>+  // Don't call up to our superclass, since neither nsDOMGenericSH nor
>+  // nsEventTargetSH have WANT_ENUMERATE.
Want to assert here that 
!(GetScriptableFlags() & nsIXPCScriptable::WANT_ENUMERATE)


>+  NS_IMETHOD Enumerate(nsIXPConnectWrappedNative* wraper, JSContext* cx,
wraper

Comment 8

[Boris Zbarsky [:bzbarsky]]

Made those fixes and:

https://hg.mozilla.org/integration/mozilla-inbound/rev/776479701858
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fd6e192a220
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d0293dcec1e

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/776479701858
https://hg.mozilla.org/mozilla-central/rev/0fd6e192a220
https://hg.mozilla.org/mozilla-central/rev/8d0293dcec1e