Do not fall back to tenured if we fail to allocate in the nursery when NoGC

RESOLVED FIXED in Firefox 39

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla39
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8573337 [details] [diff] [review]
dont_fallback_from_nursery_to_tenured_alloc_on_nogc-v0.diff

We have a hugely complicated infrastructure around allocation for the new object cache to allow us to clear the nursery when it fills up without clobbering the cache itself. This is dumb. Unlike with CanGC, where failure usually kills the script, when we're allocating with NoGC, we're already prepared to retry on failure, so making a best effort makes no sense. If we just return false on nursery alloc failure, we have an insubstantially lower hit rate, but we can dump the enormous complexity.

Try run looks green modulo 2 cgc failures -- a missing annotation in the previous patch -- and what looks like a random orange -- I've retriggered a few runs to check:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=73c6c968bbb3
Attachment #8573337 - Flags: review?(bhackett1024)
Attachment #8573337 - Flags: review?(bhackett1024) → review+
https://hg.mozilla.org/mozilla-central/rev/9a2b3b8289ee
Assignee: nobody → terrence
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.