Re-enable tests on linux debug b2g desktop that were disabled by bug 1103106

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: martijn.martijn, Assigned: martijn.martijn)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(1 attachment, 1 obsolete attachment)

Bug 1103106 isn't fixed, but the assertions was changed into an non-fatal one, so I think we can re-enable all the tests on linux debug b2g desktop that were suffering from it.
Apparently, there is no Gip on linux64 debug running anywhere on treeherder, so this wouldn't be tested anyway.

Johnathan, do you know the situation of linux64 debug running Gip on treeherder?
If it's not run and there are no plans on get it running there, then I don't see any reason why these disablings should still be in there.
QA Whiteboard: [fxosqa-auto-s11]
Depends on: 1107205
Flags: needinfo?(jgriffin)
The tests are running on debug linux64 on cedar, where they're failing.
Flags: needinfo?(jgriffin)
(In reply to Jonathan Griffin (:jgriffin) from comment #3)
> The tests are running on debug linux64 on cedar, where they're failing.

How can I get this pr tested on cedar then?
Flags: needinfo?(jgriffin)
This patch should be a no-op for non-debug tests, so I'd recommend just landing it, and then asking for a merge to cedar.
Flags: needinfo?(jgriffin)
Comment on attachment 8574663 [details] [review]
[gaia] mwargers:assertion > mozilla-b2g:master

These tests are only run on cedar, not on regular try.
Attachment #8574663 - Flags: review?(gmealer)
Comment on attachment 8574663 [details] [review]
[gaia] mwargers:assertion > mozilla-b2g:master

LGTM, but you're going to have to rebase it first because of the other recent manifest adjustments. 

As long as there are no try test issues once you update the PR, fine by me to change me to r+ and go ahead and land.

Unfortunately, I can't do r+ up front because Autolander will try to land it. Not even sure what happens with merge conflicts if I do that.
Afaik, autolander will only land it once you add the 'checkin-needed' keyword.
Comment on attachment 8575370 [details] [review]
[gaia] mwargers:assertion2 > mozilla-b2g:master

Sorry, had to create a new pull request, I don't know how to solve all these merge issues that I got.
Attachment #8575370 - Flags: review?(jdorlus)
Attachment #8575370 - Flags: review?(gmealer)
Attachment #8574663 - Attachment is obsolete: true
Attachment #8574663 - Flags: review?(gmealer)
Attachment #8575370 - Flags: review?(jdorlus) → review+
Comment on attachment 8575370 [details] [review]
[gaia] mwargers:assertion2 > mozilla-b2g:master

LGTM.
Attachment #8575370 - Flags: review?(gmealer) → review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.