1139999 - Re-enable tests on linux debug b2g desktop that were disabled by bug 1103106

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

Bug 1103106 isn't fixed, but the assertions was changed into an non-fatal one, so I think we can re-enable all the tests on linux debug b2g desktop that were suffering from it.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:assertion > mozilla-b2g:master

Comment 2

[Martijn Wargers (dead)]

Apparently, there is no Gip on linux64 debug running anywhere on treeherder, so this wouldn't be tested anyway.

Johnathan, do you know the situation of linux64 debug running Gip on treeherder?
If it's not run and there are no plans on get it running there, then I don't see any reason why these disablings should still be in there.

Comment 3

[Jonathan Griffin (:jgriffin)]

The tests are running on debug linux64 on cedar, where they're failing.

Comment 4

[Martijn Wargers (dead)]

(In reply to Jonathan Griffin (:jgriffin) from comment #3)
> The tests are running on debug linux64 on cedar, where they're failing.

How can I get this pr tested on cedar then?

Comment 5

[Jonathan Griffin (:jgriffin)]

This patch should be a no-op for non-debug tests, so I'd recommend just landing it, and then asking for a merge to cedar.

Comment 6

[Martijn Wargers (dead)]

Comment on attachment 8574663 [details] [review]
[gaia] mwargers:assertion > mozilla-b2g:master

These tests are only run on cedar, not on regular try.

Comment 7

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 8574663 [details] [review]
[gaia] mwargers:assertion > mozilla-b2g:master

LGTM, but you're going to have to rebase it first because of the other recent manifest adjustments. 

As long as there are no try test issues once you update the PR, fine by me to change me to r+ and go ahead and land.

Unfortunately, I can't do r+ up front because Autolander will try to land it. Not even sure what happens with merge conflicts if I do that.

Comment 8

[Martijn Wargers (dead)]

Afaik, autolander will only land it once you add the 'checkin-needed' keyword.

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:assertion2 > mozilla-b2g:master

Comment 10

[Martijn Wargers (dead)]

Comment on attachment 8575370 [details] [review]
[gaia] mwargers:assertion2 > mozilla-b2g:master

Sorry, had to create a new pull request, I don't know how to solve all these merge issues that I got.

Comment 11

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 8575370 [details] [review]
[gaia] mwargers:assertion2 > mozilla-b2g:master

LGTM.

Comment 12

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/fd616836cf7b08f1d03eb50ca5651d93b5df950f