1140044 - Bookmarks button in browser menu does not update title when state changes, affecting a11y

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The title on these assets is used in accessibility to describe the interaction. In this case, the title is always "Bookmark" [1], but this is not helpful when removing bookmarks. Your task:

* Add a string for "Remove bookmark" (look into m/a/b/strings.xml & m/a/b/locales/en-US/android_strings.dtd) 
* Dynamically update the title so that the correct title is applied to the action (look into m/a/b/BrowserApp.java)
* Enable accessibility to test your work! (Note: this may take a bit of learning to use)

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/locales/en-US/android_strings.dtd#44

Comment 1

[Jeff Lu]

Attachment: bug-1140044.patch

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8579644 [details] [diff] [review]
bug-1140044.patch

Review of attachment 8579644 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm! Thanks Jeff!

Here's a try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8853fb2842b2

Add "checkin-needed" once it goes green!

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/d51655b90787

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Jeff, if you'd like some followup work, perhaps you'd like to work on bug 1145252 or bug 1146730? Let me know if you would prefer something else too.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d51655b90787