Closed
Bug 1140099
Opened 10 years ago
Closed 10 years ago
Remove wait for "busy" attribute to be gone in the Tab object's constructor
Categories
(Testing :: Firefox UI Tests, defect)
Testing
Firefox UI Tests
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla39
People
(Reporter: chmanchester, Assigned: chmanchester)
References
Details
Attachments
(1 file)
The check is here: https://github.com/mozilla/firefox-ui-tests/blob/37736b3257e761e6c05fa3033edd3ee4670bbd14/firefox_puppeteer/ui/tabbar.py#L216
This attribute's removal seems to wait for network activity to stop, so if we use open_tab in a way that ends up opening a remote page we're likely to fail the 5 second timeout.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8573652 -
Flags: review?(hskupin)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8573652 [details] [review]
PR to remove the wait
Looks good. I will get it landed in a moment.
Attachment #8573652 -
Flags: review?(hskupin) → review+
|
|
||
Comment 3•10 years ago
|
||
PR got merged as https://github.com/mozilla/firefox-ui-tests/commit/d609ba58d80d21e2b4989ffda4106fb4595179f5. Thanks!
Assignee: nobody → cmanchester
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
|
||
Updated•9 years ago
|
Product: Mozilla QA → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•