enable graphene builds on try

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
3 years ago
2 months ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
There's no reason we can't run them there. We should make them default off though.

Try chooser probably needs an update too.
(Assignee)

Comment 1

3 years ago
Created attachment 8573931 [details] [diff] [review]
enable graphene on try

I'm pretty sure try_by_default is false, so this should be the only thing we need in buildbot-configs....
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #8573931 - Flags: review?(jlund)
(Assignee)

Comment 2

3 years ago
Created attachment 8573975 [details] [diff] [review]
add graphene options to trychooser

I'm not 100% sure if the platform values are correct. The platforms in b2g_config.py match these, but the builder names are different. Eg:  graphene_larch_linux64 build

I think you're the resident expert here, Steve :).
Attachment #8573975 - Flags: review?(sphink)
Comment on attachment 8573975 [details] [diff] [review]
add graphene options to trychooser

Review of attachment 8573975 [details] [diff] [review]:
-----------------------------------------------------------------

Looks right to me, assuming I'm reading b2g_config.py correctly. It seems to say -p linux64_graphene is the way to get that build.
Attachment #8573975 - Flags: review?(sphink) → review+

Comment 4

3 years ago
Comment on attachment 8573931 [details] [diff] [review]
enable graphene on try

Review of attachment 8573931 [details] [diff] [review]:
-----------------------------------------------------------------

this should almost do it but, iiuc, we need a couple more things.

try_by_default is itself, defaulted to True if we don't define it: http://mxr.mozilla.org/build/search?string=try_by_default&find=misc&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=build

so I think we need to add it and set it to false in the graphene pf config in a similar fashion to hazard builds: http://mxr.mozilla.org/build/source/buildbot-configs/mozilla/config.py#676

also, unfortunately, since try has its own slavepool, we need to explicitly tell try about this platform like we do for these: http://mxr.mozilla.org/build/source/buildbot-configs/mozilla/config.py#2741

r- for now till patch is updated or I'm proven to be inaccurate in my review :)
Attachment #8573931 - Flags: review?(jlund) → review-
(Assignee)

Comment 5

3 years ago
(In reply to Jordan Lund (:jlund) from comment #4)
> Comment on attachment 8573931 [details] [diff] [review]
> enable graphene on try
> 
> Review of attachment 8573931 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> this should almost do it but, iiuc, we need a couple more things.
> 
> try_by_default is itself, defaulted to True if we don't define it:
> http://mxr.mozilla.org/build/
> search?string=try_by_default&find=misc&findi=&filter=%5E%5B%5E%5C0%5D*%24&hit
> limit=&tree=build

That link seems to prove what you say, but I'm confused. Doesn't that mean pushes will get a whole bunch of things run by default that we don't want?

> also, unfortunately, since try has its own slavepool, we need to explicitly
> tell try about this platform like we do for these:
> http://mxr.mozilla.org/build/source/buildbot-configs/mozilla/config.py#2741

Ah, good catch. Thanks!

Comment 6

3 years ago
(In reply to Ben Hearsum [:bhearsum] from comment #5)
> (In reply to Jordan Lund (:jlund) from comment #4)
> > Comment on attachment 8573931 [details] [diff] [review]
> > enable graphene on try
> > 
> > Review of attachment 8573931 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > this should almost do it but, iiuc, we need a couple more things.
> > 
> > try_by_default is itself, defaulted to True if we don't define it:
> > http://mxr.mozilla.org/build/
> > search?string=try_by_default&find=misc&findi=&filter=%5E%5B%5E%5C0%5D*%24&hit
> > limit=&tree=build
> 
> That link seems to prove what you say, but I'm confused. Doesn't that mean
> pushes will get a whole bunch of things run by default that we don't want?

I'm pretty sure that if a dev uses 'try: -b do -p all' the only try build builders they won't get are the False guys from here(linux64-sh-haz, linux64-cc, and win64-debug): http://mxr.mozilla.org/build/search?string=try_by_default&find=mozilla%2F&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=build
(Assignee)

Comment 7

3 years ago
Created attachment 8574814 [details] [diff] [review]
graphene try, #2

I think I fixed both of the issues you identified - thanks!
Attachment #8573931 - Attachment is obsolete: true
Attachment #8574814 - Flags: review?(jlund)
Doh! Sorry, I should have read the initial comments in this bug. I just assumed you wanted these to run on try by default.

> > try_by_default is itself, defaulted to True if we don't define it:
> > http://mxr.mozilla.org/build/
> > search?string=try_by_default&find=misc&findi=&filter=%5E%5B%5E%5C0%5D*%24&hit
> > limit=&tree=build
> 
> That link seems to prove what you say, but I'm confused. Doesn't that mean
> pushes will get a whole bunch of things run by default that we don't want?

There aren't very many things that are off by default on try. And it's weird how that works, too. eg the various spidermonkey builds are associated with regular platforms, but the hazard builds and graphene builds are their own platforms. So -p linux64 will get all of the nondefault spidermonkey builds, whether you wanted them or not. On the other hand, the weirdo platforms feel like a misuse of the data model and are hard to discover.

I'm still surprised trychooser hasn't collapsed under its own weight yet. :-)

Comment 9

3 years ago
Comment on attachment 8574814 [details] [diff] [review]
graphene try, #2

Review of attachment 8574814 [details] [diff] [review]:
-----------------------------------------------------------------

afaict, lgtm :)
Attachment #8574814 - Flags: review?(jlund) → review+
(Assignee)

Updated

3 years ago
Attachment #8573975 - Flags: checked-in+
(Assignee)

Updated

3 years ago
Attachment #8574814 - Flags: checked-in+
(Assignee)

Comment 10

3 years ago
I had to land a silly typo fix for try chooser, but it's updated now: https://hg.mozilla.org/build/tools/rev/9633d1651564
(Assignee)

Comment 11

3 years ago
Needed a bustage fix for buildbot-configs too, because try has an explicit list of platforms: https://hg.mozilla.org/build/buildbot-configs/rev/a0eac491d154 and http://hg.mozilla.org/build/buildbot-configs/rev/87f23e9b7073
(Assignee)

Comment 13

3 years ago
These builders are on try now, and can be run with try syntax like "try: -b o -p linux64_graphene,macosx64_graphene,win64_graphene -u none -t none", which is selectable with http://trychooser.pub.build.mozilla.org/
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Depends on: 1186764
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.