Closed Bug 1140210 Opened 5 years ago Closed 4 years ago

Improve MenuItemActionView readability

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- unaffected
firefox45 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

(Blocks 2 open bugs)

Details

Attachments

(4 files)

MenuItemActionView refers a View that:
  * Shows text if there is enough space and there are no action buttons (mActionButtons)
  * Shows an icon if there is not enough space for text
  * Also shows icons as 

i.e. quick share in the browser menu.

MenuItemActionBar refers to any other item in the browser menu, e.g. back, forward.
Assignee: nobody → michael.l.comella
Summary: Rename MenuItemActionView and MenuItemActionBar → Improve MenuItemActionView readability
Bug 1140210 - MenuItemActionView -> MenuItemSwitcherLayout. r=liuche
Attachment #8674535 - Flags: review?(liuche)
Bug 1140210 - Add class comment to MenuItemSwitcherLayout. r=liuche
Attachment #8674536 - Flags: review?(liuche)
Bug 1140210 - menu_item_action_view -> menu_item_switcher_layout. r=liuche
Attachment #8674537 - Flags: review?(liuche)
Bug 1140210 - Rename MenuItemActionView styles to new name. r=liuche
Attachment #8674538 - Flags: review?(liuche)
Comment on attachment 8674535 [details]
MozReview Request: Bug 1140210 - MenuItemActionView -> MenuItemSwitcherLayout. r=liuche

https://reviewboard.mozilla.org/r/22243/#review20783
Attachment #8674535 - Flags: review?(liuche) → review+
Comment on attachment 8674536 [details]
MozReview Request: Bug 1140210 - Add class comment to MenuItemSwitcherLayout. r=liuche

https://reviewboard.mozilla.org/r/22245/#review20785
Attachment #8674536 - Flags: review?(liuche) → review+
Comment on attachment 8674537 [details]
MozReview Request: Bug 1140210 - menu_item_action_view -> menu_item_switcher_layout. r=liuche

https://reviewboard.mozilla.org/r/22247/#review20787
Attachment #8674537 - Flags: review?(liuche) → review+
Attachment #8674538 - Flags: review?(liuche) → review+
Comment on attachment 8674538 [details]
MozReview Request: Bug 1140210 - Rename MenuItemActionView styles to new name. r=liuche

https://reviewboard.mozilla.org/r/22249/#review20789

This all looks good to me, rename + checking all the references to it have been updated.
re backout: see bug 1140048 comment 83. We should rebase and reland this. It will force the patches in bug 1140048 to be rebased so I'll change from depends on to blocking.
Blocks: 1140048
No longer depends on: 1140048
You need to log in before you can comment on or make changes to this bug.