Closed
Bug 1140210
Opened 10 years ago
Closed 10 years ago
Improve MenuItemActionView readability
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox44 unaffected, firefox45 fixed)
RESOLVED
FIXED
Firefox 44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | unaffected |
| firefox45 | --- | fixed |
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(4 files)
MenuItemActionView refers a View that:
* Shows text if there is enough space and there are no action buttons (mActionButtons)
* Shows an icon if there is not enough space for text
* Also shows icons as
i.e. quick share in the browser menu.
MenuItemActionBar refers to any other item in the browser menu, e.g. back, forward.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → michael.l.comella
|
|
Assignee | |
Updated•10 years ago
|
Summary: Rename MenuItemActionView and MenuItemActionBar → Improve MenuItemActionView readability
|
|
Assignee | |
Comment 1•10 years ago
|
||
Bug 1140210 - MenuItemActionView -> MenuItemSwitcherLayout. r=liuche
Attachment #8674535 -
Flags: review?(liuche)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Bug 1140210 - Add class comment to MenuItemSwitcherLayout. r=liuche
Attachment #8674536 -
Flags: review?(liuche)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Bug 1140210 - menu_item_action_view -> menu_item_switcher_layout. r=liuche
Attachment #8674537 -
Flags: review?(liuche)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Bug 1140210 - Rename MenuItemActionView styles to new name. r=liuche
Attachment #8674538 -
Flags: review?(liuche)
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8674535 [details]
MozReview Request: Bug 1140210 - MenuItemActionView -> MenuItemSwitcherLayout. r=liuche
https://reviewboard.mozilla.org/r/22243/#review20783
Attachment #8674535 -
Flags: review?(liuche) → review+
|
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8674536 [details]
MozReview Request: Bug 1140210 - Add class comment to MenuItemSwitcherLayout. r=liuche
https://reviewboard.mozilla.org/r/22245/#review20785
Attachment #8674536 -
Flags: review?(liuche) → review+
|
|
||
Comment 7•10 years ago
|
||
Comment on attachment 8674537 [details]
MozReview Request: Bug 1140210 - menu_item_action_view -> menu_item_switcher_layout. r=liuche
https://reviewboard.mozilla.org/r/22247/#review20787
Attachment #8674537 -
Flags: review?(liuche) → review+
|
|
||
Updated•10 years ago
|
Attachment #8674538 -
Flags: review?(liuche) → review+
|
|
||
Comment 8•10 years ago
|
||
Comment on attachment 8674538 [details]
MozReview Request: Bug 1140210 - Rename MenuItemActionView styles to new name. r=liuche
https://reviewboard.mozilla.org/r/22249/#review20789
This all looks good to me, rename + checking all the references to it have been updated.
|
|
Assignee | |
Comment 9•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/5b439b4654e00b882c8cfde06b41872b3515161b
Bug 1140210 - MenuItemActionView -> MenuItemSwitcherLayout. r=liuche
https://hg.mozilla.org/integration/fx-team/rev/8345f21f651819dddce7412e4f5a7046ed4f0d69
Bug 1140210 - Add class comment to MenuItemSwitcherLayout. r=liuche
https://hg.mozilla.org/integration/fx-team/rev/156585c07b3da57636bb01213ecfad506060553c
Bug 1140210 - menu_item_action_view -> menu_item_switcher_layout. r=liuche
https://hg.mozilla.org/integration/fx-team/rev/623b15184f2a3da0e2b339a70fbdf49595b19b80
Bug 1140210 - Rename MenuItemActionView styles to new name. r=liuche
|
||
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5b439b4654e0
https://hg.mozilla.org/mozilla-central/rev/8345f21f6518
https://hg.mozilla.org/mozilla-central/rev/156585c07b3d
https://hg.mozilla.org/mozilla-central/rev/623b15184f2a
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
|
|
Assignee | |
Comment 11•10 years ago
|
||
Backout of 44, to cleanly backout bug 1140048: https://hg.mozilla.org/releases/mozilla-aurora/rev/6e11b576f3ce
status-firefox45:
--- → fixed
|
|
Assignee | |
Comment 12•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/e804e442d303eae31503afd950da6b0da06fad1e
Bug 1140210 - Backout 4 changesets to backout top level share plane (bug 1140048).
| Comment hidden (typo) |
|
|
Assignee | |
Comment 14•10 years ago
|
||
re backout: see bug 1140048 comment 83. We should rebase and reland this. It will force the patches in bug 1140048 to be rebased so I'll change from depends on to blocking.
|
|
Assignee | |
Comment 15•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/016c6968c7a7bdb5c21276972c07f62f41c585bc
Bug 1140210 - MenuItemActionView -> MenuItemSwitcherLayout. r=liuche
https://hg.mozilla.org/integration/fx-team/rev/5b88f76c0f2d48ea913f96d74be79d44cc0fda43
Bug 1140210 - Add class comment to MenuItemSwitcherLayout. r=liuche
https://hg.mozilla.org/integration/fx-team/rev/5aa9937df2eaad0c67ec2221e9e4890071cdd388
Bug 1140210 - menu_item_action_view -> menu_item_switcher_layout. r=liuche
https://hg.mozilla.org/integration/fx-team/rev/40a6f2d22128d1f18340eb1f594b3bc639fcdd1e
Bug 1140210 - Rename MenuItemActionView styles to new name. r=liuche
https://hg.mozilla.org/integration/fx-team/rev/a349189606c73906151a306c7a0446337d298a6c
Bug 1140210 - Fix build errors after rebase. r=me
|
|
||
Comment 16•10 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/016c6968c7a7
https://hg.mozilla.org/mozilla-central/rev/5b88f76c0f2d
https://hg.mozilla.org/mozilla-central/rev/5aa9937df2ea
https://hg.mozilla.org/mozilla-central/rev/40a6f2d22128
https://hg.mozilla.org/mozilla-central/rev/a349189606c7
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•