Closed Bug 1140216 Opened 5 years ago Closed 5 years ago

"Assertion failure: mSpinDown" with CSS: input { -moz-appearance: textfield; }

Categories

(Core :: Layout: Form Controls, defect, critical)

Product:
Core
Component:
Layout: Form Controls
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: jruderman, Assigned: bzbarsky)

References

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

testcase
282 bytes, text/html
Details
stack
5.46 KB, text/plain
Details
Remove asserts that stuff that we never create is not null, since it clearly is null
2.05 KB, patch
jwatt
: review+
Details | Diff | Splinter Review
Attached file testcase — 
Assertion failure: mSpinDown, at layout/forms/nsNumberControlFrame.cpp:818
Attached file stack — 
So apparently we do this purposefully!

In nsNumberControlFrame::CreateAnonymousContent we skip creating mSpinBox, mSpinUp, and mSpinDown if StyleDisplay()->mAppearance == NS_THEME_TEXTFIELD.

Which means that asserting anything about them existing is just bogus, since clearly they don't have to exist.  The asserts were added in the same bug as the check above (bug 947728) and I think they just need to go away.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8573701 [details] [diff] [review]
Remove asserts that stuff that we never create is not null, since it clearly is null

For consistency add the comment to the nsCSSPseudoElements::ePseudo_mozNumberSpinUp case too.
Attachment #8573701 - Flags: review?(jwatt) → review+
https://hg.mozilla.org/mozilla-central/rev/5133b5b2e4a2
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.