1140216 - "Assertion failure: mSpinDown" with CSS: input { -moz-appearance: textfield; }

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Assertion failure: mSpinDown, at layout/forms/nsNumberControlFrame.cpp:818

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Boris Zbarsky [:bzbarsky]]

So apparently we do this purposefully!

In nsNumberControlFrame::CreateAnonymousContent we skip creating mSpinBox, mSpinUp, and mSpinDown if StyleDisplay()->mAppearance == NS_THEME_TEXTFIELD.

Which means that asserting anything about them existing is just bogus, since clearly they don't have to exist.  The asserts were added in the same bug as the check above (bug 947728) and I think they just need to go away.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove asserts that stuff that we never create is not null, since it clearly is null

Comment 4

[Jonathan Watt [:jwatt]]

Comment on attachment 8573701 [details] [diff] [review]
Remove asserts that stuff that we never create is not null, since it clearly is null

For consistency add the comment to the nsCSSPseudoElements::ePseudo_mozNumberSpinUp case too.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Did that and https://hg.mozilla.org/integration/mozilla-inbound/rev/5133b5b2e4a2

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5133b5b2e4a2