1140220 - [RTL] When attaching an image from Camera to MMS or to a Contact, the confirmation buttons are NOT mirrored

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P2)

Description

[Pi Wei Cheng [:piwei] (inactive)]

Description:
When sending a photo MMS by Camera, or when setting a contact's portrait by Camera, the confirmation buttons are not mirrored in RTL.

Prerequisite:
In RTL language (Arabic)

STR:
1) Go to Messages > start a new message > add attachment > select Camera > take a photo, observe the following screen

Expected: The left button is Select, right button is Retake

Actual: The left button is Retake, right button is Select, same as LTR.

Device: Flame 3.0
BuildID: 20150305010212
Gaia: eff3321ab4e65da3f906688ebb55ddf1e93d9452
Gecko: 56492f7244a9
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 1

[Pi Wei Cheng [:piwei] (inactive)]

2.2 is also affected.

Device: Flame 2.2
BuildID: 20150305002528
Gaia: 89af288bad6751248ff84504fa898206fee127fe
Gecko: 6d8d294aa8f3
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: screenshot of issue

Comment 3

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15923/

Comment 4

[Delphine Lebédel [:delphine - Use needinfo]]

This is a P2 and we're one week away from FC. I think a fix would be good here to ensure consistency across all apps. Flagging Hema so she can assign this to someone. thanks!

Comment 5

[Punam Dahiya [:pdahiya]]

Taking bug to submit fix.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] punamdahiya:Bug1140220 > mozilla-b2g:master

Comment 7

[Punam Dahiya [:pdahiya]]

Comment on attachment 8586311 [details] [review]
[gaia] punamdahiya:Bug1140220 > mozilla-b2g:master

Hi Wilson

Please review attached patch that updates confirm buttons to use flex layout so that it honors direction change in RTL mode. Thanks!

Comment 8

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/2f37b4fba7c6ae460d5713d96621fc81411d36af

Comment 9

[Punam Dahiya [:pdahiya]]

Comment on attachment 8586311 [details] [review]
[gaia] punamdahiya:Bug1140220 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Not a regression
[User impact] if declined:  In RTL mode , When sending a photo MMS by Camera the confirmation buttons are not mirrored.
[Testing completed]: On master
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: None

Comment 10

[Norry.L.F(Leave from Mozilla)]

Hi Delphine, 

This bug can be still repro on Flame 2.2, could you confirm whether the patch will land on v2.2 or not?
Thanks.

Comment 11

[Delphine Lebédel [:delphine - Use needinfo]]

Hi Norry, as per comment 9, the patch is waiting approval before it can land on 2.2. We just need to wait for :bajaj to approve that, and then you will see it land on 2.2 as well.

Comment 12

[Norry.L.F(Leave from Mozilla)]

Sorry for that I missed flags on commen9. Thanks, Delphine :)

Comment 13

[Lancy(Leave from Mozilla)]

Attachment: Verify1_Flame3.0_Pass.png

According to the comment 0, this issue has been verified pass on latest Flame 3.0 build.
See attachment:Verify1_Flame3.0_Pass.png.
Reproducing rate:0/10

Flame 3.0 build (Unaffected):
Build ID               20150402160202
Gaia Revision          62042ffcc8c6cca0f51ad23f5c2b979fc153b5a7
Gaia Date              2015-04-02 16:01:42
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/513265a4cbc2
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150402.192125
Firmware Date          Thu Apr  2 19:21:37 EDT 2015
Bootloader             L1TC000118D0

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/fda19d0d723d01c77d7de3e5333f34a456fc58b7

Comment 15

[Lancy(Leave from Mozilla)]

Attachment: Verify2_Flame2.2_Pass.png

According to the steps in comment 0, the issue has been verified pass on latest Flame 2.2 build:
See attachment:Verify2_Flame2.2_Pass.png
Reproducing rate:0/10

Flame 2.2 build (Unaffected):
Build ID               20150406002503
Gaia Revision          a6351e1197d54f8624523c2db9ba1418f2aa046f
Gaia Date              2015-04-03 22:06:41
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c3335a5d3063
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150406.040047
Firmware Date          Mon Apr  6 04:00:58 EDT 2015
Bootloader             L1TC000118D0