Closed Bug 1140221 Opened 11 years ago Closed 9 years ago

Intermittent test-tabs.js.testIgnoreClosing | Test timed out (after: should be two tabs in total) | test-tabs.js.testOpenInNewWindow | Test timed out | Should not be any unexpected windows open

Categories

(Add-on SDK Graveyard :: General, defect, P1)

Product:
Add-on SDK Graveyard
Component:
General
Platform:
All
Windows 8.1
Type:
defect

Tracking

(firefox38 unaffected, firefox39 affected, firefox40 affected, firefox-esr31 unaffected)

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox38 --- unaffected
firefox39 --- affected
firefox40 --- affected
firefox-esr31 --- unaffected

People

(Reporter: KWierso, Assigned: evold)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

pull request
46 bytes, text/x-github-pull-request
evold
: review+
Details | Review
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1980
46 bytes, text/x-github-pull-request
jsantell
: review+
Details | Review
14:51:26 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testBug682681_aboutURI | title of about: tab is not blank 14:51:26 INFO - TEST-INFO | executing 'jetpack-package/addon-sdk/source/test/test-tabs.js.testFaviconGetterDeprecation' 14:51:26 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testFaviconGetterDeprecation | only one error is dispatched 14:51:26 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testFaviconGetterDeprecation | error 14:51:26 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testFaviconGetterDeprecation | message contains the given message 14:51:26 INFO - TEST-INFO | executing 'jetpack-package/addon-sdk/source/test/test-tabs.js.testIgnoreClosing' 14:51:27 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testIgnoreClosing | should be two windows open each with one tab 14:51:27 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testIgnoreClosing | should be two tabs in the new window 14:51:27 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testIgnoreClosing | should be three tabs in total 14:51:27 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testIgnoreClosing | should be one tab in the new window 14:51:27 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testIgnoreClosing | should be two tabs in total 14:51:41 WARNING - TEST-UNEXPECTED-FAIL | jetpack-package/addon-sdk/source/test/test-tabs.js.testIgnoreClosing | Test timed out (after: should be two tabs in total) 14:51:41 INFO - TEST-INFO | Traceback (most recent call last): 14:51:41 INFO - File "resource://gre/modules/commonjs/sdk/timers.js", line 40, in notify 14:51:41 INFO - callback.apply(null, args); 14:51:41 INFO - File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 490, in tiredOfWaiting 14:51:41 INFO - self.console.testMessage(false, false, self.test.name, 14:51:41 INFO - File "resource://gre/modules/commonjs/sdk/test/harness.js", line 543, in testMessage 14:51:41 INFO - this.trace(); 14:51:41 INFO - TEST-INFO | executing 'jetpack-package/addon-sdk/source/test/test-tabs.js.testInBackground' 14:51:41 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testInBackground | Should be one tab 14:51:41 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testInBackground | getMostRecentBrowserWindow() matches this window 14:51:42 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testInBackground | URL of active tab has not changed 14:51:42 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testInBackground | URL of the new background tab matches 14:51:42 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testInBackground | a new window was not opened 14:51:42 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testInBackground | URL of active tab is not the new URL 14:51:42 INFO - TEST-INFO | executing 'jetpack-package/addon-sdk/source/test/test-tabs.js.testOnLoadEventWithDOM' 14:51:42 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testOnLoadEventWithDOM | tab passed in as arg, load called 14:51:42 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testOnLoadEventWithDOM | first onLoad event occured 14:51:42 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testOnLoadEventWithDOM | tab passed in as arg, load called 14:51:42 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testOnLoadEventWithDOM | onLoad event called on reload 14:51:42 INFO - TEST-INFO | executing 'jetpack-package/addon-sdk/source/test/test-tabs.js.testOnLoadEventWithImage' 14:51:42 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testOnLoadEventWithImage | first onLoad event occured 14:51:42 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testOnLoadEventWithImage | onLoad event called on reload with image 14:51:42 INFO - TEST-INFO | executing 'jetpack-package/addon-sdk/source/test/test-tabs.js.testOpen' 14:51:42 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testOpen | URL of the new tab matches 14:51:42 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testOpen | The new tab is not pinned 14:51:42 INFO - TEST-INFO | executing 'jetpack-package/addon-sdk/source/test/test-tabs.js.testOpenInNewWindow' 14:51:43 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testOpenInNewWindow | a new window was opened 14:51:57 WARNING - TEST-UNEXPECTED-FAIL | jetpack-package/addon-sdk/source/test/test-tabs.js.testOpenInNewWindow | Test timed out (after: a new window was opened) 14:51:57 INFO - TEST-INFO | Traceback (most recent call last): 14:51:57 INFO - File "resource://gre/modules/commonjs/sdk/timers.js", line 40, in notify 14:51:57 INFO - callback.apply(null, args); 14:51:57 INFO - File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 490, in tiredOfWaiting 14:51:57 INFO - self.console.testMessage(false, false, self.test.name, 14:51:57 INFO - File "resource://gre/modules/commonjs/sdk/test/harness.js", line 543, in testMessage 14:51:57 INFO - this.trace(); 14:51:57 WARNING - TEST-UNEXPECTED-FAIL | jetpack-package/addon-sdk/source/test/test-tabs.js.testOpenInNewWindow | Should not be any unexpected windows open 14:51:57 INFO - TEST-INFO | Traceback (most recent call last): 14:51:57 INFO - File "resource://gre/modules/Promise-backend.js", line 688, in this.PromiseWalker.scheduleWalkerLoop/< 14:51:57 INFO - DOMPromise.resolve().then(() => this.walkerLoop()); 14:51:57 INFO - File "resource://gre/modules/Promise-backend.js", line 746, in this.PromiseWalker.walkerLoop 14:51:57 INFO - this.handlers.shift().process(); 14:51:57 INFO - File "resource://gre/modules/Promise-backend.js", line 867, in Handler.prototype.process 14:51:57 INFO - nextValue = this.onResolve.call(undefined, nextValue); 14:51:57 INFO - File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 334, in done/< 14:51:57 INFO - this.fail("Should not be any unexpected windows open"); 14:51:57 INFO - File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 104, in fail 14:51:57 INFO - this.console.testMessage(false, false, this.test.name, message); 14:51:57 INFO - File "resource://gre/modules/commonjs/sdk/test/harness.js", line 543, in testMessage 14:51:57 INFO - this.trace(); 14:51:57 INFO - TEST-INFO | Windows open: 14:51:57 INFO - TEST-INFO | chrome://browser/content/browser.xul - about:blank 14:51:57 INFO - TEST-INFO | chrome://browser/content/browser.xul - data:text/html;charset=utf-8,testOpenInNewWindow 14:51:58 INFO - TEST-INFO | executing 'jetpack-package/addon-sdk/source/test/test-tabs.js.testOpenInNewWindowOnOpen' 14:52:13 WARNING - TEST-UNEXPECTED-FAIL | jetpack-package/addon-sdk/source/test/test-tabs.js.testOpenInNewWindowOnOpen | Test timed out (after: START) 14:52:13 INFO - TEST-INFO | Traceback (most recent call last): 14:52:13 INFO - File "resource://gre/modules/commonjs/sdk/timers.js", line 40, in notify 14:52:13 INFO - callback.apply(null, args); 14:52:13 INFO - File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 490, in tiredOfWaiting 14:52:13 INFO - self.console.testMessage(false, false, self.test.name, 14:52:13 INFO - File "resource://gre/modules/commonjs/sdk/test/harness.js", line 543, in testMessage 14:52:13 INFO - this.trace(); 14:52:13 WARNING - TEST-UNEXPECTED-FAIL | jetpack-package/addon-sdk/source/test/test-tabs.js.testOpenInNewWindowOnOpen | Should not be any unexpected windows open 14:52:13 INFO - TEST-INFO | Traceback (most recent call last): 14:52:13 INFO - File "resource://gre/modules/Promise-backend.js", line 688, in this.PromiseWalker.scheduleWalkerLoop/< 14:52:13 INFO - DOMPromise.resolve().then(() => this.walkerLoop()); 14:52:13 INFO - File "resource://gre/modules/Promise-backend.js", line 746, in this.PromiseWalker.walkerLoop 14:52:13 INFO - this.handlers.shift().process(); 14:52:13 INFO - File "resource://gre/modules/Promise-backend.js", line 867, in Handler.prototype.process 14:52:13 INFO - nextValue = this.onResolve.call(undefined, nextValue); 14:52:13 INFO - File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 334, in done/< 14:52:13 INFO - this.fail("Should not be any unexpected windows open"); 14:52:13 INFO - File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 104, in fail 14:52:13 INFO - this.console.testMessage(false, false, this.test.name, message); 14:52:13 INFO - File "resource://gre/modules/commonjs/sdk/test/harness.js", line 543, in testMessage 14:52:13 INFO - this.trace(); 14:52:13 INFO - TEST-INFO | Windows open: 14:52:13 INFO - TEST-INFO | chrome://browser/content/browser.xul - about:blank 14:52:13 INFO - TEST-INFO | chrome://browser/content/browser.xul - data:text/html;charset=utf-8,newwindow 14:52:13 INFO - TEST-INFO | executing 'jetpack-package/addon-sdk/source/test/test-tabs.js.testOpenPinned' 14:52:13 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testOpenPinned | The new tab is pinned 14:52:13 INFO - TEST-INFO | executing 'jetpack-package/addon-sdk/source/test/test-tabs.js.testPerTabEvents' 14:52:13 INFO - TEST-PASS | jetpack-package/addon-sdk/source/test/test-tabs.js.testPerTabEvents | both listeners notified 14:52:14 INFO - TEST-INFO | executing 'jetpack-package/addon-sdk/source/test/test-tabs.js.testPinUnpin'
Blocks: sdk-intermittent
Priority: -- → P1
Hardware: x86_64 → All
This is one of our top M(JP) oranges (and a frequent failure overall). Can we please get some activity on it?
Flags: needinfo?(dtownsend)
Attached file pull request —
Looks like some problems with focus in windows 8 64 bit only :( This patch makes sure the new window is focused before proceeding and then uses onFocus on the old window before ending. It might help.
Flags: needinfo?(dtownsend)
Attachment #8594175 - Flags: review?(evold)
Attachment #8594175 - Flags: review?(evold) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/6b888f56d4034108fadc892e782efbf97376d300 Bug 1140221: Use DOM focus events to wait for new and old windows to focus before proceeding. https://github.com/mozilla/addon-sdk/commit/75fb6ae70bfdecb1d5c21b6cacc7592d0b710cc8 Merge pull request #1937 from Mossop/bug1140221 Bug 1140221: Use DOM focus events to wait for new and old windows to focus before proceeding. r=erikvold
https://hg.mozilla.org/mozilla-central/rev/bc08f3773fb4
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Assignee: nobody → dtownsend
status-firefox38: --- → unaffected
status-firefox39: --- → affected
status-firefox-esr31: --- → unaffected
Status: RESOLVED → REOPENED
status-firefox39: fixed → affected
status-firefox40: fixed → affected
Resolution: FIXED → ---
Target Milestone: mozilla40 → ---
I'm reasonably convinced that this is tied up with the focus issues in bug 1135545 but I don't have time to work on this further.
Assignee: dtownsend → nobody
Assignee: nobody → evold
Attachment #8613836 - Flags: review?(jsantell) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/bfe7504c68cc328c2fd8fe6f434be263a2abd2b9 Bug 1140221 - avoid openBrowserWindow in test-tabs.js.testIgnoreClosing https://github.com/mozilla/addon-sdk/commit/15fc5439e2f8a6b09349ee4b90dcce63f8040eb5 Merge pull request #1980 from erikvold/1140221 Bug 1140221 - avoid openBrowserWindow in test-tabs.js.testIgnoreClosing r=jsantell
Blocks: 1206321
no failure in the last 5 months - closing as wfm
Status: REOPENED → RESOLVED
Closed: 10 years ago → 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: