1140242 - Don't try to send nsILoginInfo between processes

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Matthew N. [:MattN]]

I found out in bug 1139718 that password manager messages that try to send an XPCOM object e.g. nsILoginInfo lose their ability to send structured clones since structured cloning of XPCOM objects fails so the code falls back to stringifying the arguments. This means we lose nicety of Structured Clones e.g. for RegExp, Map, Set, etc. [1] as we get vanilla objects.

Fixing this allows me to send RegExp and Set across processes like I originally wanted to.

[1] https://developer.mozilla.org/en-US/docs/Web/Guide/API/DOM/The_structured_clone_algorithm

Comment 1

[Matthew N. [:MattN]]

Attachment: MozReview Request: bz://1140242/MattN

/r/4937 - Bug 1140242 - Convert nsILoginInfo to vanilla JS objects before trying to send them in messages. r=dolske

Pull down this commit:

hg pull review -r ba1259ef0be9fa3be2bd39a075e8518eb1e90e57

Comment 2

[Matthew N. [:MattN]]

All tests pass locally. See also bug 1139718 comment 9.

Comment 3

[Justin Dolske [:Dolske]]

Huh, so do I understand this correctly? The issue is that the clone of the xpcom object (login) fails, and so it falls back to JSON. Which is actually OK for the login itself, but has the side effect of _other_ things in the message being cloned breaking because of the JSON fallback?

That's... awful. But at least the workaround is simple.

Comment 4

[Justin Dolske [:Dolske]]

Comment on attachment 8573679 [details]
MozReview Request: bz://1140242/MattN

https://reviewboard.mozilla.org/r/4935/#review4133

Ship It!

Comment 5

[Matthew N. [:MattN]]

(In reply to Justin Dolske [:Dolske] from comment #3)
> Huh, so do I understand this correctly? The issue is that the clone of the
> xpcom object (login) fails, and so it falls back to JSON. Which is actually
> OK for the login itself, but has the side effect of _other_ things in the
> message being cloned breaking because of the JSON fallback?
> 
> That's... awful. But at least the workaround is simple.

Yep, that's correct.

Also, btw. I didn't add a test for this specifically since it will be easily caught by recipe tests using Set/RegExp.

https://hg.mozilla.org/integration/fx-team/rev/ed7f8e7ab386

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ed7f8e7ab386

Comment 8

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1140242 - Convert nsILoginInfo to vanilla JS objects before trying to send them in messages. r=dolske