1140358 - Fix fetch-win32-symbols to work properly for Win64 symbols

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[(not currently active) Ted Mielczarek]

bug 1120126 noted a problem that turns out to be with my fetch-win32-symbols setup: the symbols we're fetching for Win64 binaries from Microsoft don't have unwind data because we're not fetching the matching .dll files, which Breakpad needs to dump the unwind data on Win64.

Upstream Breakpad added support for this to the ms_symbol_server_converter code we're using so hopefully it's just a matter of recompiling the binaries:
https://code.google.com/p/google-breakpad/source/detail?r=1309

Comment 1

[Robert Kaiser]

Note that the current plans call for shipping Win64 with 38, which is on Dev Edition now and hits Beta at the end of this month. It would be good if stack unwinding works fine during Beta-testing this version.

I know you're usually pretty swamped, how soon do you think this can be done?

Comment 2

[(not currently active) Ted Mielczarek]

If we get bug 1140937 fixed this shouldn't be too hard to roll into the work I'm doing to fix bug 1140392.

Comment 3

[(not currently active) Ted Mielczarek]

I had made some changes in the script to support this scenario a while ago:
http://hg.mozilla.org/users/tmielczarek_mozilla.com/fetch-win32-symbols/rev/751aaded179b

Since bug 1140937 went live we now have that data in the missing-symbols cron output, so I updated the docker image I was using to run this task and kicked off a new run with it:
https://tools.taskcluster.net/task-graph-inspector/#erCa2BTnQVKYwF2jZN3DHg

If that works properly then we can call this fixed!

Comment 4

[(not currently active) Ted Mielczarek]

This seems to be working properly. I looked at the symbols it's uploaded recently and there are useful symbols for Win64 system libs, like:
https://s3-us-west-2.amazonaws.com/org.mozilla.crash-stats.symbols-public/v1/kernel32.pdb/9CC5A0AF30A24F7A9A026888FF670FEC1/kernel32.sym

Hooray!