1140399 - Add friend API to check whether a function has a JSNative and get the JSNative of a function

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Need this for bug 1131802.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Add friend API to check whether a given function object has a JSNative and to get that JSNative as needed

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8573963 [details] [diff] [review]
Add friend API to check whether a given function object has a JSNative and to get that JSNative as needed

Review of attachment 8573963 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: js/src/jsfriendapi.h
@@ +2393,5 @@
>  
> +namespace js {
> +
> +static MOZ_ALWAYS_INLINE shadow::Function *
> +FunctionObjectToShadowFunction(JSObject* fun)

Nit: JSObject *fun

@@ +2395,5 @@
> +
> +static MOZ_ALWAYS_INLINE shadow::Function *
> +FunctionObjectToShadowFunction(JSObject* fun)
> +{
> +    MOZ_ASSERT(js::GetObjectClass(fun) == FunctionClassPtr);

Nit: can remove the js:: here.

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5de3c4e663e7

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5de3c4e663e7