Closed Bug 1140493 Opened 10 years ago Closed 8 years ago

The ReaderModeButton should have a better a11y label

Categories

(Firefox for iOS :: Reader View, defect)

Product:
Firefox for iOS
Component:
Reader View
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: st3fan, Unassigned)

References

Details

It should probably be something more descriptive than just "Reader". It should also change when the button status (readability availability) changes. We may be able to ignore the disabled state but available and enabled should translate to something like "Switch to Reader View" and "Switch back to Browser View" - Not sure what the correct terminology should be.
Cc to :dusek .. we are not blocking on this for v1, but we would take a patch.
(In reply to Stefan Arentz [:st3fan] from comment #2) > Cc to :dusek .. we are not blocking on this for v1, but we would take a > patch. Currently it says either "Reader Mode" or "selected, Reader mode". I will think whether that is OK, or whether having more explicit labels is better. (btw., the proposed https://github.com/dusek/firefox-ios/commit/82bfb4b144045787626971ba774390445dbc7f30 from https://github.com/mozilla/firefox-ios/pull/497 changes the label from "Reader Mode" to the correct term "Reader View"). To sum it up, a patch itself is trivial, but the decision what is the correct label is less trivial :-) I will think about it.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.