Closed
Bug 1140573
Opened 9 years ago
Closed 9 years ago
Remove the parent argument from JS_NewFunction and other JSNative function-creating APIs
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(4 files)
14.26 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
3.33 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
9.04 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
7.74 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
Since we don't need a parent for a scope chain there, and there are no APIs for getting it from elsewhere, we don't need it at all.
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8574231 -
Flags: review?(jwalden+bmo)
![]() |
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8574232 -
Flags: review?(jwalden+bmo)
![]() |
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8574233 -
Flags: review?(jwalden+bmo)
![]() |
Assignee | |
Comment 4•9 years ago
|
||
Attachment #8574234 -
Flags: review?(jwalden+bmo)
Updated•9 years ago
|
Attachment #8574231 -
Flags: review?(jwalden+bmo) → review+
Updated•9 years ago
|
Attachment #8574232 -
Flags: review?(jwalden+bmo) → review+
Updated•9 years ago
|
Attachment #8574233 -
Flags: review?(jwalden+bmo) → review+
Updated•9 years ago
|
Attachment #8574234 -
Flags: review?(jwalden+bmo) → review+
![]() |
Assignee | |
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ba663870636 https://hg.mozilla.org/integration/mozilla-inbound/rev/04c874c96837 https://hg.mozilla.org/integration/mozilla-inbound/rev/cdeac41a30aa https://hg.mozilla.org/integration/mozilla-inbound/rev/358970f124d7
https://hg.mozilla.org/mozilla-central/rev/0ba663870636 https://hg.mozilla.org/mozilla-central/rev/04c874c96837 https://hg.mozilla.org/mozilla-central/rev/cdeac41a30aa https://hg.mozilla.org/mozilla-central/rev/358970f124d7
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•