Remove the parent argument from JS_NewFunction and other JSNative function-creating APIs

RESOLVED FIXED in Firefox 39

Status

()

Core
JavaScript Engine
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla39
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(4 attachments)

Since we don't need a parent for a scope chain there, and there are no APIs for getting it from elsewhere, we don't need it at all.
Created attachment 8574231 [details] [diff] [review]
part 1.  Drop the parent argument from JS_NewFunction
Attachment #8574231 - Flags: review?(jwalden+bmo)
Created attachment 8574232 [details] [diff] [review]
part 2.  Drop the parent argument from JS_NewFunctionById
Attachment #8574232 - Flags: review?(jwalden+bmo)
Created attachment 8574233 [details] [diff] [review]
part 3.  Drop the parent argument from js::NewFunctionWithReserved
Attachment #8574233 - Flags: review?(jwalden+bmo)
Created attachment 8574234 [details] [diff] [review]
part 4.  Drop the parent argument from js::NewFunctionByIdWithReserved
Attachment #8574234 - Flags: review?(jwalden+bmo)

Updated

3 years ago
Attachment #8574231 - Flags: review?(jwalden+bmo) → review+

Updated

3 years ago
Attachment #8574232 - Flags: review?(jwalden+bmo) → review+

Updated

3 years ago
Attachment #8574233 - Flags: review?(jwalden+bmo) → review+

Updated

3 years ago
Attachment #8574234 - Flags: review?(jwalden+bmo) → review+
You need to log in before you can comment on or make changes to this bug.