browser_net_security-details.js failure from the NSS 3.18 RC0 landing

RESOLVED FIXED in Firefox 38

Status

()

Firefox
Developer Tools: Netmonitor
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: philor, Assigned: Sami Jaktholm)

Tracking

Trunk
Firefox 39
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox38 fixed, firefox39 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
The NSS update from bug 1137470 increased NSS's default maximum supported version of TLS from 1.0 to 1.2, which caused http://mxr.mozilla.org/mozilla-central/source/browser/devtools/netmonitor/test/browser_net_security-details.js#40 to fail because it expects exactly a TLSv1 connection without having done anything to ensure it gets one.

I'll land a change to increase that to expecting exactly a TLSv1.2 connection once I have the number from this bug to use in a commit message, but the test really needs to do something else, either ensure that it will get a particular version or not test that it has gotten a particular version.

Comment 2

3 years ago
We'll also need this on Aurora, because 3.18 RTM will have to land there.
status-firefox38: --- → affected
(Reporter)

Comment 3

3 years ago
You can land test-only changes on aurora with a=test-only, no need to worry about that.
(Assignee)

Comment 4

3 years ago
Created attachment 8574317 [details] [diff] [review]
netmonitor-security-test-fix.patch

Here's a patch that makes the test work with different TLS protocol versions and cipher suites. It changes the test not to assume any specific values but to check if the values look valid i.e. the protocol version starts with "TLS" and the cipher suite starts with "TLS_".

This should be quite a bit more future proof.

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7eb480adbb12
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Attachment #8574317 - Flags: review?(vporof)
Comment on attachment 8574317 [details] [diff] [review]
netmonitor-security-test-fix.patch

Review of attachment 8574317 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8574317 - Flags: review?(vporof) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/13e4ad55d827
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
(Assignee)

Updated

3 years ago
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/13e4ad55d827
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39

Comment 9

3 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/1adf44fcb513

(This is the combination of Phil's first patch, and the later patch on top.)
status-firefox38: affected → fixed
You need to log in before you can comment on or make changes to this bug.