1140739 - browser_net_security-details.js failure from the NSS 3.18 RC0 landing

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Phil Ringnalda (:philor)]

The NSS update from bug 1137470 increased NSS's default maximum supported version of TLS from 1.0 to 1.2, which caused http://mxr.mozilla.org/mozilla-central/source/browser/devtools/netmonitor/test/browser_net_security-details.js#40 to fail because it expects exactly a TLSv1 connection without having done anything to ensure it gets one.

I'll land a change to increase that to expecting exactly a TLSv1.2 connection once I have the number from this bug to use in a commit message, but the test really needs to do something else, either ensure that it will get a particular version or not test that it has gotten a particular version.

Comment 1

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5cfc2a0f0054

Comment 2

[Kai Engert (:KaiE:)]

We'll also need this on Aurora, because 3.18 RTM will have to land there.

Comment 3

[Phil Ringnalda (:philor)]

You can land test-only changes on aurora with a=test-only, no need to worry about that.

Comment 4

[Sami Jaktholm]

Attachment: netmonitor-security-test-fix.patch

Here's a patch that makes the test work with different TLS protocol versions and cipher suites. It changes the test not to assume any specific values but to check if the values look valid i.e. the protocol version starts with "TLS" and the cipher suite starts with "TLS_".

This should be quite a bit more future proof.

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7eb480adbb12

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5cfc2a0f0054

Comment 6

[Victor Porof [:vporof][:vp]]

Comment on attachment 8574317 [details] [diff] [review]
netmonitor-security-test-fix.patch

Review of attachment 8574317 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/13e4ad55d827

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/13e4ad55d827

Comment 9

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1adf44fcb513

(This is the combination of Phil's first patch, and the later patch on top.)