1140751 - [ga-IE] Firefox for iOS v1 localization for Irish

Status: RESOLVED FIXED

(Mozilla Localizations :: ga-IE / Irish, defect)

Comment 1

[Francesco Lodolo [:flod]]

File added in r138889.

Comment 2

[Axel Hecht [:Pike]]

Kevin, http://viewvc.svn.mozilla.org/vc/projects/l10n-misc/trunk/firefox-ios/ga-IE/firefox-ios.xliff?r1=138968&r2=138969&pathrev=138969&limit_changes=100 isn't going to work, sorry.

You'll need the <source> string to be English, and add your translation in <target> elements. See https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localizing_XLIFF_files

Comment 3

[Kevin Scannell]

Not sure what was going through my head.  Fixed now.

Comment 4

[Axel Hecht [:Pike]]

One more technical thing, you'll also need to add target-language="ga" or ga-IE to all the file elements.

Comment 5

[Kevin Scannell]

Done.  I'll read the documentation next time.

Comment 6

[Gordon P. Hemsley [:GPHemsley]]

We're still perpetuating 'ga-IE'? ;_;

Comment 7

[Jeff Beatty [:gueroJeff]]

Hey Kevin,

Xcode is throwing an import error, likely due to double quotes in the "Mark as Unread" = "Marcáil "Neamhléite""; string. Could you take a look to make sure the same double quotes are being used between source and target please?

Comment 8

[Jeff Beatty [:gueroJeff]]

@Gordon: maintaining consistency :-)

Comment 9

[Kevin Scannell]

We'd like to have double quotes in the translation.  Probably a bug to fix somewhere in the pipeline - probably in conversion from Pootle to xliff it should be converted to " ?

Comment 10

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The problem is that the generated .strings file looks like this:

"Mark as Read" = "Marcáil "Léite"";
"Mark as Unread" = "Marcáil "Neamhléite"";

I think it is totally fine to have double quotes in a string, but they need to be properly escaped. I wonder if that is actually a bug in Apple's tool that converts .xliff to .strings. Because in a XLIFF XML file, a " has no special meaning (I think?) and it should really be the responsibility of the conversion tool to put it properly in the .strings file.

If this is a bug and you really need a double quote, maybe use a different double quote? Like the nice ones that point to the left and right?

Comment 11

[Kevin Scannell]

Thanks Stefan - I can change to the unicode quotes as a quick fix, but this is probably something to report/fix.

Comment 12

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I mean the curly quotes .. 

U+201C LEFT DOUBLE QUOTATION MARK
U+201D RIGHT DOUBLE QUOTATION MARK

It is a bit of a silly workaround .. but maybe this looks ok?

Kevin, I will report this with Apple. Sure sounds like a bug to me.

Comment 13

[Kevin Scannell]

Yup, I just changed the translations in Pootle to use U+201C/D.  Thanks again.

Comment 14

[Jeff Beatty [:gueroJeff]]

Hi Kevin,

Checking in for a sign-off status for v1. If you would like to ship your work in v1, please resolve this bug as FIXED before Friday, 14 August.

Thanks,
Jeff

Comment 15

[Kevin Scannell]

Will signoff tomorrow - need one more build cycle in order to see/test my latest changes live.

Comment 16

[Jeff Beatty [:gueroJeff]]

Sounds good. Thanks! Hope you enjoyed your time in the Ayran Isles ;-)

Comment 17

[Kevin Scannell]

Any hope of a quick fix to Bug 1178119 before I sign off?  It looks bad in testing.

Comment 18

[Jeff Beatty [:gueroJeff]]

I just ping Stefan. Hoping it can be resolved quickly.

Comment 19

[Jeff Beatty [:gueroJeff]]

(In reply to Kevin Scannell from comment #17)
> Any hope of a quick fix to Bug 1178119 before I sign off?  It looks bad in
> testing.

Do you see this as a blocker to your shipping ga-IE in v1?

Comment 20

[Kevin Scannell]

No, not a blocker.  It's really just the one string, and not a super-prominent one.  A fix in 1.1 would be awesome.

Comment 21

[Jeff Beatty [:gueroJeff]]

Ok, thanks for commenting. Feel free to resolve this for v1 when you're ready.

Comment 22

[Kevin Scannell]

1.0 (32) looks good to ship!

Comment 23

[Jeff Beatty [:gueroJeff]]

Excellent! Thanks!