Closed Bug 1140802 Opened 9 years ago Closed 9 years ago

Deleting an event in the view after opening the event dialog via double-click causes a MODIFICATION_FAILED error


(Calendar :: Calendar Frontend, defect)

Not set


(Not tracked)



(Reporter: mmecca, Assigned: mmecca)



(1 file)

This is a follow up to Bug 1120258.

Opening an event for editing by double-clicking the event in the view, then deleting the event in the view while the dialog is still open, results in a MODIFICATION_FAILED error. Opening the event dialog using the view context menu, or from the today pane or unifinder, does not trigger the same error.
Attached patch Fix v1Splinter Review
Currently, opening the event dialog by double-clicking an item in the view is the only method that calls into the createPendingModification function, which tracks pending modification jobs in the event dialog, and attempts to complete those changes first if a subsequent modification is made before the dialog is closed. Since the fix for Bug 1120258 landed, that is no longer necessary, as the event dialog will observe those changes.
Attachment #8574360 - Flags: review?(philipp)
Attachment #8574360 - Flags: approval-calendar-aurora?(philipp)
Comment on attachment 8574360 [details] [diff] [review]
Fix v1

Review of attachment 8574360 [details] [diff] [review]:

Lets do it, thanks for looking into this! r/a=philipp
Attachment #8574360 - Flags: review?(philipp)
Attachment #8574360 - Flags: review+
Attachment #8574360 - Flags: approval-calendar-aurora?(philipp)
Attachment #8574360 - Flags: approval-calendar-aurora+
Keywords: checkin-needed
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.1
Checkin for comm-aurora (4.0) is still missing!
You need to log in before you can comment on or make changes to this bug.