Closed
Bug 1140898
Opened 11 years ago
Closed 11 years ago
[e10s] "View" > "Switch Page Direction" doesn't work in e10s
Categories
(Firefox :: Menus, defect)
Firefox
Menus
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| e10s | m7+ | --- |
People
(Reporter: Kwan, Assigned: Kwan)
References
(Blocks 1 open bug)
Details
Attachments
(1 obsolete file)
Triggers a "TypeError: aWindow is null" in browser.js
|
Assignee | |
Comment 1•11 years ago
|
||
Relies on the patch in bug 1140878.
|
||
Updated•11 years ago
|
|
|
Assignee | |
Comment 3•11 years ago
|
||
(In reply to Mike Conley (:mconley) - Needinfo me! from comment #2)
> Is this patch ready for review?
Indeed it is, as is the one in bug 1140878, I was just saving them until you'd gotten through the others I'd bombarded you with.
Flags: needinfo?(moz-ian)
|
|
||
Comment 4•11 years ago
|
||
Bah, bombard away. Having invisible r? is less useful than visible r?. ;)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8574458 -
Flags: review?(mconley)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8574458 [details] [diff] [review]
Make 'View' > 'Switch Page Direction' use messages so it works in e10s
Review of attachment 8574458 [details] [diff] [review]:
-----------------------------------------------------------------
We'll want to use Browser:SwitchDocumentDirection, since we renamed it in the other patch.
This looks good to me. Thanks again Ian!
Attachment #8574458 -
Flags: review?(mconley) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Comment on attachment 8574458 [details] [diff] [review]
Make 'View' > 'Switch Page Direction' use messages so it works in e10s
Marking obsolete as it's been folded into the patch in bug 1140878.
Attachment #8574458 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•11 years ago
|
||
Fixed by the combined patch in bug 1140878.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•