1140970 - Move icons in Reader View controls up 2px

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: 2015-03-08 00.38.48.png

They're perfectly aligned right now as per the spec but because of the divider they look more off than they should. Optically, offsetting it would make them seem more "aligned". This wasn't as noticeable in the design so that was my fault. It's especially noticeable now when there is not as a much text in the area.

This seems like a quick fix. I think 2px should do it! (or 1px, heh)

Comment 1

[:Margaret Leibovic]

We probably just need to edit this .button style:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/aboutReader.css#318

Comment 2

[Pete Chambers]

Hi, can I please be assigned this bug? Thanks Pete

Comment 3

[:Margaret Leibovic]

Hi Pete, welcome! Let me know if you need help working on this bug.

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Pete Chambers from comment #2)
> Hi, can I please be assigned this bug? Thanks Pete

Thanks for picking this up Pete! Specifically, let's just move up the Add to Reading List icon, Remove from Reading List icon, Aa, Aa (active), and Share icon up 2 px. 

Post a screenshot when you're ready and let's see how it looks! :)

Comment 5

[Pete Chambers]

Okay thanks Margaret, and will do Anthony! :)

Comment 6

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

No problem Pete! We can work together to see what looks best. This deliberate off-set to optically align the icons might be a little bit finicky.

Comment 7

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Controls have changed so this doesn't apply anymore.