Move icons in Reader View controls up 2px

RESOLVED INVALID

Status

()

RESOLVED INVALID
4 years ago
3 years ago

People

(Reporter: antlam, Assigned: petechambers1992, Mentored)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=css][good next bug])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Created attachment 8574515 [details]
2015-03-08 00.38.48.png

They're perfectly aligned right now as per the spec but because of the divider they look more off than they should. Optically, offsetting it would make them seem more "aligned". This wasn't as noticeable in the design so that was my fault. It's especially noticeable now when there is not as a much text in the area.

This seems like a quick fix. I think 2px should do it! (or 1px, heh)

Comment 1

4 years ago
We probably just need to edit this .button style:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/aboutReader.css#318
Mentor: margaret.leibovic
Whiteboard: [lang=css][good next bug]
(Assignee)

Comment 2

4 years ago
Hi, can I please be assigned this bug? Thanks Pete

Comment 3

4 years ago
Hi Pete, welcome! Let me know if you need help working on this bug.
Assignee: nobody → petechambers1992
(Reporter)

Comment 4

4 years ago
(In reply to Pete Chambers from comment #2)
> Hi, can I please be assigned this bug? Thanks Pete

Thanks for picking this up Pete! Specifically, let's just move up the Add to Reading List icon, Remove from Reading List icon, Aa, Aa (active), and Share icon up 2 px. 

Post a screenshot when you're ready and let's see how it looks! :)
(Assignee)

Comment 5

4 years ago
Okay thanks Margaret, and will do Anthony! :)
(Reporter)

Comment 6

4 years ago
No problem Pete! We can work together to see what looks best. This deliberate off-set to optically align the icons might be a little bit finicky.
(Reporter)

Comment 7

3 years ago
Controls have changed so this doesn't apply anymore.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.