1140971 - Return the TR 0x04 when receive the stk command contains icons to display

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[jinghua.xing]

For STK_CMD_LAUNCH_BROWSER、STK_CMD_PLAY_TONE、STK_CMD_DISPLAY_TEXT、STK_CMD_GET_INKEY、STK_CMD_GET_INPUT、STK_CMD_SET_UP_IDLE_MODE_TEXT、STK_CMD_SET_UP_MENU and STK_CMD_SELECT_ITEM commands， the TR STK_RESULT_PRFRMD_ICON_NOT_DISPLAYED should be sent if there are icons in the command as the test cases[1] and the protocol [2] says.

[1] 3GPP TS 51.010-4 V12.1.0
[2] ETSI TS 101 267 6.4

Comment 1

[jinghua.xing]

All the USAT cases below should send 0x04 TR from gaia side:

27.22.4.1.5 DISPLAY TEXT SEQ 5.1B  DISPLAY TEXT, display of basic icon, self-explanatory, requested icon could not be displayed
27.22.4.2.6 GET INKEY SEQ 6.1B	GET INKEY, Basic icon, self-explanatory, requested icon could not be displayed
27.22.4.3.6 GET INPUT SEQ 6.1B	GET INPUT, Basic icon, self-explanatory, requested icon could not be displayed
27.22.4.5.3 PLAY TONE SEQ 3.1B	PLAY TONE, Basic icon, self-explanatory, requested icon could not be displayed
27.22.4.8.4 SET UP MENU SEQ 4.1B	SET UP MENU, BASIC ICON NOT SELF EXPLANATORY in ALPHA ID and ITEMS DATA OBJECTS, requested icon could not be displayed
27.22.4.9.5 SELECT ITEM SEQ 5.1B  SELECT ITEM, BASIC ICON NOT SELF EXPLANATORY, requested icon could not be displayed
27.22.4.22.2 SET UP IDLE MODE TEXT SEQ 2.1B    SET UP IDLE MODE TEXT, Icon is self-explanatory, requested icon could not be displayed
27.22.4.26.4 LAUNCH BROWSER SEQ 4.1B LAUNCH BROWSER, use the existing browser, icon not self explanatory,
requested icon could not be displayed

Comment 2

[jinghua.xing]

Sean

Can you help to check this issue please?

Thank

Comment 3

[Sean Lee [:seanlee][:weilonge]]

Attachment: Trail Patch for v2.1s

Hi Jinghua,

Here is a trial patch for you to verify the issue.
Thank you.

Comment 4

[jinghua.xing]

Sean:

For SET_UP_MENU and SELECT_ITEM command, the icons and iconSelfExplanatory property are also may contained in each item in the command, so we also should use the code below to judge whether we should use 0x04 or 0x01 as the result code in the TR:

      var hasIcon = message.command.options.items.some(function(item) {
        return item.icons || item.iconSelfExplanatory;
      });
      var iconResult;
      if (message.command.options.iconSelfExplanatory ||
          message.command.options.icons || hasIcon) {
        iconResult = icc._iccManager.STK_RESULT_PRFRMD_ICON_NOT_DISPLAYED;
      } else {
        iconResult = icc._iccManager.STK_RESULT_OK;
      }

For example, in test case 27.22.4.8.4 SET UP MENU SEQ 4.1B, the command send from ril_worker to radiointerface is :

01-27 06:07:30.330   131   131 I Gecko   : -*- RadioInterface[0]: Received message from worker: {"commandNumber":1,"typeOfCommand":37,"commandQualifier":0,"rilMessageType":"stkcommand","options":{"title":"Toolkit Menu","items":[{"identifier":1,"text":"Item 1","icons":[{"pixels":[4294967295,4294967295,4294967295,4294967295,4294967295,4294967295,4294967295,255,4294967295,4294967295,4294967295,255,4294967295,255,4294967295,4294967295,4294967295,255,4294967295,4294967295,4294967295,4294967295,4294967295,4294967295,4294967295],"codingScheme":"basic","width":5,"height":5}],"iconSelfExplanatory":false},{"identifier":2,"text":"Item 2","icons":[{"pixels":[4294967295,4294967295,4294967295,4294967295,4294967295,4294967295,4294967295,255,4294967295,4294967295,4294967295,255,4294967295,255,4294967295,4294967295,4294967295,255,4294967295,4294967295,4294967295,4294967295,4294967295,4294967295,4294967295],"codingScheme":"basic","width":5,"height":5}],"iconSelfExplanatory":false},{"identifier":3,"text":"Item 3","icons":[{"pixels":[4294967295,4294967295,4294967295,429

Comment 5

[Sean Lee [:seanlee][:weilonge]]

Attachment: Trail Patch for v2.1s

Hi Jinghua,

Thanks for your information.
I've updated the patch. Can you give some suggestions?
Thank you.

Comment 6

[jinghua.xing]

Sean：

Sorry for the delay. I think your patch is ok for this issue. Thank you,

Comment 7

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8575232 [details]
Trail Patch for v2.1s

Hi Fernando,

Could you help to review the patch?
Thank you.

Comment 8

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 8575232 [details]
Trail Patch for v2.1s

LGTM

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/STK/v2.1/Bug1140971 > mozilla-b2g:v2.1

Comment 10

[Sean Lee [:seanlee][:weilonge]]

Attachment: PR for v2.1

Hi Fernando,

Sorry that I made a mistake that the previous patch is not a PR format.
This one is identical to the previous one.
Could you help to review the PR again?

Thank you.

Comment 11

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8579780 [details] [review]
PR for v2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
We did not implement the following spec:
[1] 3GPP TS 51.010-4 V12.1.0
[2] ETSI TS 101 267 6.4

[Testing completed]:
Partner is accepted the patch at comment 6.

[Risk to taking this patch] (and alternatives if risky):
Just changing the command of each TR mentioned at comment 0.

[String changes made]:
None

Comment 12

[Maria Angeles Oteo (:oteo)]

Hi Sean, in case this patch need to be uplifted to 2.1 you need to nominate it to that branch (apart of asking for the approval).
Just one question, does this bug only happen in 2.1 branch? what about 2.2 or master? Setting qawanted to confirm it.

Comment 13

[Maria Angeles Oteo (:oteo)]

> Just one question, does this bug only happen in 2.1 branch? what about 2.2
> or master? Setting qawanted to confirm it.

It seems that Bug 1016807 landed in 2.2 and master already provides support for STK icon display in those branches, that's the reason for this specific patch in 2.1 branch

Comment 14

[Sean Lee [:seanlee][:weilonge]]

Hi Maria,

Your comment 13 is correct that bug 1016807 has already fixed to support icon display.
In branch v2.1, we don't support icon display, but it still has to send an alternative Terminal Response (TR) to describe that there is no icon display feature.

My patch attachment 8579780 [details] [review] is for sending the alternative TR to follow the spec.

Thank you very much!

Comment 15

[bhavana bajaj [:bajaj]]

we are only taking critical blocking issues on 2.1 at this time and I don't why we would block on this. 2.1S is being handle by Steven yang, please NI him on getting this landed there.

Comment 16

[Steven Yang [:styang]]

Let's get it landed for 2.1S.

Comment 17

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/STK/v2.1s/Bug1140971 > mozilla-b2g:v2.1s

Comment 18

[Sean Lee [:seanlee][:weilonge]]

v2.1s: https://github.com/mozilla-b2g/gaia/commit/2eaa318c0029cd61495e857a32d23f2816026824

Comment 19

[Josh Cheng [:josh]]

Comment on attachment 8579780 [details] [review]
PR for v2.1

Remove approval request per comment 15