1141160 - [e10s] "Reload Image" in remote browser causes unsafe CPOW usage warning

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Ian Moody [:Kwan] (UTC+0)]

+++ This bug was initially created as a clone of Bug #1133577 +++

STR:

1) Visit a site with some images that take a while to load on it in an e10s window
2) Right-click on one of the long-loading images, and choose "Reload Image"

This causes some "unsafe CPOW usage" warnings in the Browser Console.

In browser/base/content/nsContextMenu.js:

  reloadImage: function(e) {
    urlSecurityCheck(this.mediaURL,
                     this.browser.contentPrincipal,
                     Ci.nsIScriptSecurityManager.DISALLOW_SCRIPT);

    if (this.target instanceof Ci.nsIImageLoadingContent) <- Causes CPOW warning
      this.target.forceReload(); <- Causes CPOW warning
  },

Comment 1

[Ian Moody [:Kwan] (UTC+0)]

Attachment: MozReview Request: bz://1141160/Kwan

/r/5829 - Bug 1141160 - Make "Reload Image" use messages to avoid unsafe CPOW warnings

Pull down this commit:

hg pull review -r 8d156d77e1b0c50415eeb304bbd5290bd47b9663

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8581672 [details]
MozReview Request: bz://1141160/Kwan

gabor says his review queue is empty.

Comment 3

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8581672 [details]
MozReview Request: bz://1141160/Kwan

https://reviewboard.mozilla.org/r/5827/#review5205

Ship It!

Comment 4

[Ian Moody [:Kwan] (UTC+0)]

Comment on attachment 8581672 [details]
MozReview Request: bz://1141160/Kwan

/r/5829 - Bug 1141160 - Make "Reload Image" use messages to avoid unsafe CPOW warnings

Pull down this commit:

hg pull -r abefce0712bf8f2a551680747e4adcd91931c658 https://reviewboard-hg.mozilla.org/gecko/

Comment 5

[Ian Moody [:Kwan] (UTC+0)]

Right, now that I've managed to remove the try syntax from the patch description this can be checked-in.  Apologies for the bugspam caused.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d156d77e1b0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/0ca5366a72d4

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0ca5366a72d4

Comment 9

[Ian Moody [:Kwan] (UTC+0)]

Attachment: MozReview Request: Bug 1141160 - Make "Reload Image" use messages to avoid unsafe CPOW warnings