Closed Bug 1141240 Opened 6 years ago Closed 5 years ago

Persist tab history for session restore

Categories

(Firefox for iOS :: General, defect)

All
iOS 8
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fennec + ---
fxios + ---

People

(Reporter: bnicholson, Assigned: bmunar)

References

Details

Attachments

(1 file)

PR
47 bytes, text/x-github-pull-request
bnicholson
: review+
wesj
: feedback+
Details | Review
Bug 1134904 deals with saving the list of URLs for each tab; this deals with each tab's back/forward history. Part of this bug will be figuring out how to inject history entries into the WKWebView's back/forward list when we resume.
This should actually be doable using history.pushState() plus redirects (like we do for error pages).
tracking-fennec: --- → ?
tracking-fxios: --- → ?
Assignee: nobody → bmunar
Status: NEW → ASSIGNED
tracking-fennec: ? → +
This could be a slippery slope. Prepared to drop this from tracking if it becomes an issue.
Attached file PR
Attachment #8621204 - Flags: review?(bnicholson)
Comment on attachment 8621204 [details] [review]
PR

Getting closer! Left a number of cleanup comments in the PR. Looks like double-restores still aren't handled correctly yet.
Attachment #8621204 - Flags: review?(bnicholson) → feedback+
Comment on attachment 8621204 [details] [review]
PR

This looks good to me, though if wesj has time to look today, it'd also be nice to get his feedback since he worked on error pages.
Attachment #8621204 - Flags: review+
Attachment #8621204 - Flags: feedback?(wjohnston)
Attachment #8621204 - Flags: feedback+
Comment on attachment 8621204 [details] [review]
PR

Thanks!
Attachment #8621204 - Flags: feedback?(wjohnston) → feedback+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.