Closed Bug 1141241 Opened 5 years ago Closed 5 years ago

crash in mozilla::MFTDecoder::SendMFTMessage(_MFT_MESSAGE_TYPE, unsigned long)

Categories

(Core :: Audio/Video, defect, P1)

x86
Windows NT
defect

Tracking

()

VERIFIED FIXED
mozilla39
Tracking Status
firefox36 --- unaffected
firefox37 + verified
firefox38 + verified
firefox39 + verified

People

(Reporter: kairo, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-dfe4cc80-eceb-437e-bae9-66a9f2150309.
=============================================================

Top frames:
0 	xul.dll 	mozilla::MFTDecoder::SendMFTMessage(_MFT_MESSAGE_TYPE, unsigned long) 	dom/media/fmp4/wmf/MFTDecoder.cpp
1 	xul.dll 	mozilla::WMFMediaDataDecoder::ProcessDrain() 	dom/media/fmp4/wmf/WMFMediaDataDecoder.cpp
2 	xul.dll 	nsRunnableMethodImpl<void ( mozilla::crashreporter::LSPAnnotationGatherer::*)(void), void, 1>::Run() 	xpcom/glue/nsThreadUtils.h
3 	xul.dll 	mozilla::MediaTaskQueue::Runner::Run() 	dom/media/MediaTaskQueue.cpp
[...]

This is the #9 crash in 37.0b3 when only looking at crashes with URLs containing "yahoo.com".

All of those seem to be EXCEPTION_ACCESS_VIOLATION_READ at address	0x2c and happening (probably as expected) on Win7 and higher only.
Almost all the URLs I see in the URL field are youtube.com.
Kairo: Can you extract some URLs where this repros?
Flags: needinfo?(kairo)
There were a couple of comments in crash stats about YouTube as well.
Blocks: MSE
Flags: needinfo?(kairo)
Keywords: needURLs
Total Count 	URL
11 	https://www.facebook.com/
7 	https://www.youtube.com/watch?v=09R8_2nJtjg
5 	https://www.youtube.com/watch?v=zX8nZI8U9XY
4 	https://www.youtube.com/watch?v=7vlYJpBQDk0
4 	http://www.roblox.com/Mad-Paintball-streams-place?id=186976759
4 	https://www.youtube.com/watch?v=kFan8qpqZn0
3 	https://www.youtube.com/watch?v=uJUy7FfKjC8
3 	https://www.youtube.com/watch?v=vSEU1Fqt1E4
3 	https://www.youtube.com/watch?v=8FlQYl42uPg
3 	https://www.youtube.com/watch?v=P4WkUBvDWls
3 	https://www.youtube.com/watch?v=QHH_f8AxjH8
3 	https://www.youtube.com/watch?v=Fc0QmDnNy3U
3 	http://www.tycsports.com/noticias/La-insolita-simulacion-de-Oleksandr-Noyok-20150304-0012.html
3 	https://www.youtube.com/watch?v=TQN1Lsmp7Us
2 	http://www.e-earphone.jp/shopdetail/000000056114/036/P/page1/recommend/
2 	https://www.youtube.com/watch?v=89eghfyIA7M
2 	https://www.youtube.com/watch?v=RDxQPRnIMdA
2 	http://www.youtube.com/watch?v=PmGGZcbKCDU
2 	https://www.youtube.com/watch?v=a7LHo3-ufAk
2 	http://vk.com/videos186900992?z=video186900992_166688630%2Falbum186900992
2 	https://www.youtube.com/watch?v=uILpic9Gxcs
2 	https://www.youtube.com/watch?v=EbxpsraPDws
2 	https://www.youtube.com/watch?v=vSEU1Fqt1E4&feature=related
2 	https://www.youtube.com/watch?v=jMf08TXWRNs
2 	https://www.youtube.com/watch?v=Se1y2R5QRKU
2 	https://video.search.yahoo.com/video/play;_ylt=A0LEVigbKv5U8bcAUg0lnIlQ;_ylu=X3oDMTBsa3ZzMnBvBHNlYwNzYwRjb2xvA2JmMQR2dGlkAw--?p=youtube&tnr=21&vid=D4913D8265B4C87E7F74D4913D8265B4C87E7F74&l=297&turl=http%3A%2F%2Fts2.mm.bing.net%2Fth%3Fid%3DUN.607999578128
2 	https://www.youtube.com/watch?v=xxg8NRpohrY
2 	https://www.youtube.com/watch?v=WxPl3vhA9so
2 	https://www.youtube.com/watch?v=Ibwpc5AuOpU
Keywords: needURLs
Priority: -- → P1
Null pointer deref looks like.
Assignee: nobody → cpearce
Simple null check...
Attachment #8575773 - Flags: review?(matt.woodrow)
Attachment #8575773 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/3f483283a086
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Ralph, this needs uplift for MSE, can you take care of that?
Flags: needinfo?(giles)
Comment on attachment 8575773 [details] [diff] [review]
Patch: Simple nullcheck

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: This is the #9 top crash in 37b3. So user impact is crashes.
[Describe test coverage new/current, TreeHerder]: We don't know how to repro, so can't really write a test.
[Risks and why]: Low risk, just adds a nullcheck
[String/UUID change made/needed]: None.
Attachment #8575773 - Flags: approval-mozilla-beta?
Attachment #8575773 - Flags: approval-mozilla-aurora?
You beat me to it.
Flags: needinfo?(giles)
Comment on attachment 8575773 [details] [diff] [review]
Patch: Simple nullcheck

Given that we can't repro and have very few reports on Aurora and none on Nightly, I think we're going to have to prove this one on Beta. Given that it is a simple null check, I think we should test in Beta 5. Beta+ Aurora+
Attachment #8575773 - Flags: approval-mozilla-beta?
Attachment #8575773 - Flags: approval-mozilla-beta+
Attachment #8575773 - Flags: approval-mozilla-aurora?
Attachment #8575773 - Flags: approval-mozilla-aurora+
Flags: qe-verify+
There are no crashes in Socorro after the fix landed.
You can check the solutions and the methods from here at: http://www.techinpost.com/guide-for-fixing-error-102-code-problem-permanently
You need to log in before you can comment on or make changes to this bug.