1141297 - Robocop is downloaded for non-robocop emulator test jobs

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Geoff Brown [:gbrown]]

android_emulator_unittest.py downloads robocop.apk for every reftest, mochitest, etc job. It only installs it for robocop jobs. Let's be a little less wasteful.


http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-inbound-android-api-9/1425924834/mozilla-inbound_ubuntu64_vm_large_test-plain-reftest-14-bm67-tests1-linux64-build48.txt.gz

11:34:42     INFO - Downloading robocop...
11:34:42     INFO - proxxy config: {'regions': ['.use1.', '.usw2.'], 'instances': ['proxxy1.srv.releng.use1.mozilla.com', 'proxxy1.srv.releng.usw2.mozilla.com'], 'urls': [('http://ftp.mozilla.org', 'ftp.mozilla.org'), ('https://ftp.mozilla.org', 'ftp.mozilla.org'), ('https://ftp-ssl.mozilla.org', 'ftp.mozilla.org'), ('http://pvtbuilds.pvt.build.mozilla.org', 'pvtbuilds.mozilla.org'), ('http://tooltool.pvt.build.mozilla.org', 'tooltool.pvt.build.mozilla.org'), ('http://pypi.pvt.build.mozilla.org', 'pypi.pvt.build.mozilla.org'), ('http://pypi.pub.build.mozilla.org', 'pypi.pub.build.mozilla.org')]}
11:34:42     INFO - https://ftp-ssl.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-inbound-android-api-9/1425924834/robocop.apk matches https://ftp-ssl.mozilla.org
11:34:42     INFO - URL Candidate: http://ftp.mozilla.org.proxxy1.srv.releng.use1.mozilla.com/pub/mozilla.org/mobile/tinderbox-builds/mozilla-inbound-android-api-9/1425924834/robocop.apk
11:34:42     INFO - trying http://ftp.mozilla.org.proxxy1.srv.releng.use1.mozilla.com/pub/mozilla.org/mobile/tinderbox-builds/mozilla-inbound-android-api-9/1425924834/robocop.apk
11:34:42     INFO - Downloading http://ftp.mozilla.org.proxxy1.srv.releng.use1.mozilla.com/pub/mozilla.org/mobile/tinderbox-builds/mozilla-inbound-android-api-9/1425924834/robocop.apk to /builds/slave/test/build/robocop.apk
11:34:42     INFO - retry: Calling _download_file with args: ('http://ftp.mozilla.org.proxxy1.srv.releng.use1.mozilla.com/pub/mozilla.org/mobile/tinderbox-builds/mozilla-inbound-android-api-9/1425924834/robocop.apk', '/builds/slave/test/build/robocop.apk'), kwargs: {}, attempt #1
11:34:43     INFO - Downloaded 597433 bytes.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: only download if needed

We were already limiting installation of robocop.apk to jobs with names starting in "robocop"; this patch extends that logic to downloading.

Comment 2

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/build/mozharness/rev/71df988f505a

Comment 3

[Chris Cooper [:coop] (he/him)]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/71df988f505a